Fixes menu frame and unit test on the #2483.

[BDisp]

Fixes #_____ - Include a terse summary of the change or which issue is fixed.

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[BDisp]

@tig I broken the border around the listviews on the UICatalog, but I think you'll discovering that fast.

[tig]

I think you should just wait to fix these unit tests until after more of the new architecture is implemented.

Ok?

[BDisp]

@tig this should happens for your test or is an issue?

[BDisp]

@tig On the ScrollView color is failing. Maybe not a big deal but I need to look in better. OnDrawContentComplete must run after the OnRenderLineCanvas. Otherwise all the work on the OnDrawContentComplete will be damaged by the OnRenderLineCanvas.

[BDisp]

Same as #2533 (comment). The LineCanvas is bad clipped.

[BDisp]

@tig here is the explanation why the unit test Clear_Window_Inside_ScrollView is failing. Since the clipping is intentional bounds to console bounds, the container inside the scroll view overlaps the scroll view bounds. So, the fail is justified and I will comment it to pass in the checks. Then, after you are done with all yours tests, don't forgot to enable it, please. Thanks.

[BDisp]

@tig the Driver.Clip must be restored before call the OnRenderLineCanvas and the OnDrawContentComplete must be called after the OnRenderLineCanvas, unless this was intentional done for testing.

@tig can you change the .editorconfig to set the tab = 2 and not force a space before a parentheses on methods as Method()? Thanks.

[tig]

@tig can you change the .editorconfig to set the tab = 2 and not force a space before a parentheses on methods as Method()? Thanks.

Both are a Miguel/Xamarin thing. I don't think we should change it.