Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sendBeacon test for users with no ad blocker #1442

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

emma-imber
Copy link
Contributor

What does this change?

Removes the test added in #1416

Why?

The test has been running for over a week so we've got more than enough data now.

@emma-imber emma-imber requested a review from a team as a code owner June 26, 2024 14:00
Copy link

changeset-bot bot commented Jun 26, 2024

🦋 Changeset detected

Latest commit: 4a19082

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 4793ms to load.
For consentless, top-above-nav took on average 3253ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@emma-imber emma-imber merged commit ead0d88 into main Jun 26, 2024
13 checks passed
@emma-imber emma-imber deleted the ei/remove-send-beacon-test branch June 26, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants