Add test to compare sendBeacon and fetch numbers for users with no ad blocker #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 02c6fc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ad load time test resultsFor Test conditions:
|
Jakeii
approved these changes
Jun 13, 2024
|
🕵️ |
emma-imber
force-pushed
the
ei/sendbeacon-reliability-testing
branch
from
c373c9e to
02c6fc9
Compare
emma-imber
added
the
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240617102039 published to npm as a beta release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a test
sendBeaconandfetchcall to 10% of messenger background calls.Why?
Jake and Ashish realised that
sendBeaconis blocked by some ad blockers. In earlier testing, we discovered thatsendBeaconis less reliable thanfetch. It would be good to test if all of the flakiness ofsendBeaconis explained by ad blockers. By adding a test to a part of the code that only executes if there’s no ad blocker, we can see if we then observe parity betweenfetchandsendBeacon.This messenger code is only called by certain commercial templates, which will only be sending messages on the page if there is no ad blocker. This allows us to control for ad blockers, and hopefully to determine if ad blockers are the sole cause of
sendBeacon's flakiness.