check age of aws-cdk/core during ci #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
force-pushed
the
aa-aws-cdk
branch
2 times, most recently
from
cc50f77
to
21c4272
Compare
Fail the build if we're more than 5 versions out of date.
|
This isn't quite working as intended after rebasing with #191 as the diff should be 0 not 111! Will investigate. |
…ing frozen versions
jamie-lynch
reviewed
Jan 22, 2021
jamie-lynch
approved these changes
Jan 22, 2021
akash1810
added a commit
that referenced
this pull request
Apr 10, 2021
We perform a check at CI time to ensure the version of aws-cdk libraries we're using are within 5 versions of the latest available. If we're out of date, CI fails with instructions to run `./script/update-aws-cdk`. This script uses ncu (npm-check-updates) to update the aws-cdk dependencies. This change updates the call to ncu to: - Configure ncu to update the "aws-cdk" dependency in addition to @aws-cdk/* - Add the --deep flag to "Run recursively in current working directory." See: - https://www.npmjs.com/package/npm-check-updates - #192
akash1810
added a commit
that referenced
this pull request
Sep 30, 2022
Reduce friction of raising a PR by the AWS CDK version check. First introduced in #192, these checks were added to force us to keep up to date with the rapid release cadence. However as we've recently slowed down development in the repository, this requirement is causing friction for contributors. Let's remove it in favour of some automation.
akash1810
added a commit
that referenced
this pull request
Sep 30, 2022
Reduce friction of raising a PR by the AWS CDK version check. First introduced in #192, these checks were added to force us to keep up to date with the rapid release cadence. However as we've recently slowed down development in the repository, this requirement is causing friction for contributors. Let's remove it in favour of some automation.
akash1810
added a commit
that referenced
this pull request
Sep 30, 2022
Reduce friction of raising a PR by the AWS CDK version check. First introduced in #192, these checks were added to force us to keep up to date with the rapid release cadence. However as we've recently slowed down development in the repository, this requirement is causing friction for contributors. Let's remove it in favour of some automation.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We introduced dependabot in #55 to keep our dependencies up to date. However dependabot doesn't report against the CDK libraries (related dependabot/dependabot-core#1171).
This adds a fairly gnarly bash script to:
@aws-cdk/core(and assume it's ordered!)jqto find how out of date we areThis is all run in CI.
Also takes inspiration from Source and uses
npm-check-updatesto update the@aws-cdk/*libraries. All wrapped in a newupdate-aws-cdkscript.Related to #191.
*this was an arbitrary choice, we can tweak as needed
Does this change require changes to existing projects or CDK CLI?
Assuming #191 goes in first, then no.
How to test
Run the two new scripts locally:
./script/check-aws-cdk./script/update-aws-cdkHow can we measure success?
We keep up to date with
@aws-cdk/*more frequently, especially as they release fairly often.Have we considered potential risks?
Too much of a chore to keep up to date?