chore(deps): Keep aws-cdk dependencies in integration-test up to date #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We perform a check at CI time to ensure the version of aws-cdk libraries we're using are within 5 versions of the latest available. If we're out of date, CI fails with instructions to run `./script/update-aws-cdk`. This script uses ncu (npm-check-updates) to update the aws-cdk dependencies. This change updates the call to ncu to: - Configure ncu to update the "aws-cdk" dependency in addition to @aws-cdk/* - Add the --deep flag to "Run recursively in current working directory." See: - https://www.npmjs.com/package/npm-check-updates - #192
stephengeller
approved these changes
Apr 12, 2021
|
🎉 This PR is included in version 8.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
akash1810
added a commit
that referenced
this pull request
Apr 15, 2021
In #420 we updated the arguments to `ncu` to update the aws-cdk libraries. Having run the command to try to update to @aws-cdk/* v 1.98.0, it is only updating the library "aws-cdk" rather than "@aws-cdk/*" and "aws-cdk". This change switches to a regex pattern rather than multiple inputs to `ncu` and things seem much happier. ```console ➜ ./script/update-aws-cdk > @guardian/[email protected] update-aws-cdk /Users/akash_askoolum/code/cdk > ncu "/^@?aws-cdk(/.*)?$/" --upgrade --deep && npm install Upgrading /Users/akash_askoolum/code/cdk/package.json [====================] 15/15 100% @aws-cdk/assert 1.97.0 → 1.98.0 @aws-cdk/aws-apigateway 1.97.0 → 1.98.0 @aws-cdk/aws-autoscaling 1.97.0 → 1.98.0 @aws-cdk/aws-cloudwatch-actions 1.97.0 → 1.98.0 @aws-cdk/aws-ec2 1.97.0 → 1.98.0 @aws-cdk/aws-elasticloadbalancing 1.97.0 → 1.98.0 @aws-cdk/aws-elasticloadbalancingv2 1.97.0 → 1.98.0 @aws-cdk/aws-events-targets 1.97.0 → 1.98.0 @aws-cdk/aws-iam 1.97.0 → 1.98.0 @aws-cdk/aws-kinesis 1.97.0 → 1.98.0 @aws-cdk/aws-lambda 1.97.0 → 1.98.0 @aws-cdk/aws-lambda-event-sources 1.97.0 → 1.98.0 @aws-cdk/aws-rds 1.97.0 → 1.98.0 @aws-cdk/aws-s3 1.97.0 → 1.98.0 @aws-cdk/core 1.97.0 → 1.98.0 Run npm install to install new versions. Upgrading /Users/akash_askoolum/code/cdk/eslint/package.json No dependencies. Upgrading /Users/akash_askoolum/code/cdk/integration-test/package.json [====================] 1/1 100% aws-cdk 1.97.0 → 1.98.0 Run npm install to install new versions. > @guardian/[email protected] prepare /Users/akash_askoolum/code/cdk > tsc npm WARN @guardian/[email protected] No license field. updated 24 packages and audited 1807 packages in 17.102s 96 packages are looking for funding run `npm fund` for details found 51 moderate severity vulnerabilities run `npm audit fix` to fix them, or `npm audit` for details ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We perform a check at CI time to ensure the version of aws-cdk libraries we're using are within 5 versions of the latest available.
If we're out of date, CI fails with instructions to run
./script/update-aws-cdk. This script uses ncu (npm-check-updates) to update the aws-cdk dependencies.This change updates the call to ncu to:
Before (only checking
cdk/package.json)After (checking
cdk/package.json,eslint/package.jsonandintegration-test/package.json)See:
Does this change require changes to existing projects or CDK CLI?
No.
How to test
Run the
./script/update-aws-cdkscript?How can we measure success?
We update all aws-cdk dependencies in one go.
Have we considered potential risks?
n/a