Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump aws-cdk to current latest version #191

Merged
merged 3 commits into from
Jan 22, 2021
Merged

bump aws-cdk to current latest version #191

merged 3 commits into from
Jan 22, 2021

Conversation

akash1810
Copy link
Member

What does this change?

Updates AWS CDK to the latest version (latest at time of writing!). This is to keep up to date.

Does this change require changes to existing projects or CDK CLI?

I think so. As peerDependencies are not installed (unless on npm@7), we'd need to ensure dependant projects' version of AWS CDK match this.

How to test

CI should suffice.

How can we measure success?

Keeping up to date.

Have we considered potential risks?

n/a

@akash1810
Copy link
Member Author

I don't really know why this is failing, help wanted!

@jamie-lynch
Copy link
Contributor

I don't really know why this is failing, help wanted!

Wow! This looks like it's going to be a fun one 🙃

@akash1810 akash1810 marked this pull request as ready for review January 22, 2021 12:41
Copy link
Contributor

@stephengeller stephengeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me - I think had the snapshot altered, I'd be a bit more concerned, but it seems safe if the resulting yaml is fine?

Co-authored-by: Stephen Geller <[email protected]>
@akash1810 akash1810 added the needs-new-release Identifying significant changes to the library label Jan 22, 2021
@akash1810 akash1810 merged commit 0c85c1b into main Jan 22, 2021
@akash1810 akash1810 deleted the aa-bump-cdk branch January 22, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-new-release Identifying significant changes to the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants