Upgrade Vite to v8 by ryanclark · Pull Request #64600 · gravitational/teleport

ryanclark · 2026-03-13T11:09:04Z

This upgrades Vite to v8.

The build time of e goes from ~14s to ~7s, a 2x speed increase.

Rolldown (the new Rust version of rollup) was complaining about us including crypto, which was included by the crypto.randomUUID() polyfill. This method is supported in all major browsers, so I removed it.

Vite 8 now supports following paths in tsconfig.json itself, so we can remove the vite-tsconfig-paths plugin.

Will manually backport to v18 as I want to sync all the tooling dependencies first.

Manual Test Plan

Test Environment

Deployed to https://ryantest.cloud.gravitational.io

Test Cases

Ensure that Vite dev server (pnpm start-teleport-e) loads correctly and works as expected
Ensure that the built bundle loads correctly
- Verify that the ace editor (editing a role) works correctly
Verify that Connect still builds and functions correctly
Verify that Storybook still runs as expected

socket-security · 2026-03-13T11:10:22Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Maintenance
npm/rolldown@1.0.0-rc.9
npm/vite@7.3.1 ⏵ 8.0.0	^-2
npm/@vitejs/plugin-react-swc@4.2.3 ⏵ 4.3.0		⁺⁴

View full report

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a463a1b40

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

gzdunek · 2026-03-13T11:19:01Z

pnpm start-term fails with:
The electron vite main config output format must be "cjs" or "es".

I guess it's because alex8088/electron-vite#894?

ryanclark · 2026-03-13T11:22:53Z

~~Making this a draft whilst we iron out the edges (ace doesn't play nicely, audit generated docs needs fixing too)~~

Fixed these

avatus · 2026-03-13T15:19:02Z

crypto.randomUUID() polyfill. This method is supported in all major browsers,

this was added because crypto.randomUUID in the browser is only available in an HTTPS/secure context. i don't remember the usecase for it, but that was the reason for the polyfill

do you remember @rudream

avatus · 2026-03-14T15:07:38Z

disregard comment about the polyfill, i must be misremembering. it was only added for browser support #26368

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9935bcc427

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

zmb3

LGTM so long as someone from the Connect team approves

gzdunek

Connect on macOS works fine.

gzdunek · 2026-03-17T15:53:58Z

+  external: [
+    'electron',
+    /^electron\/.+/,
+    ...builtinModules.flatMap(m => [m, `node:${m}`]),
+    ...deps,
+    new RegExp(`^(${deps.join('|')})/.+`),
+  ],


From my testing, we can only externalize ['electron', 'node-pty'] and the app still works. However, it slightly increases the final DMG size (159286403 vs 158478273), so it seems reasonable to keep the current setup.

Thanks for taking the time to test

* Upgrade Vite to v8 * Remove crypto.randomUUID polyfill * Remove tsconfigPathsPlugin from everywhere * pnpm format * Update electron vite config with new options * Fix the loading of ace editor * rollupOptions -> rolldownOptions in gen-event-reference-config * Import makeEvent directly to avoid including frontend code * Fix electron config * pnpm format * Ensure ace extensions load after ace is loaded * pnpm format * Change external dependencies to only apply to main/preload * Remove unused eslint directive

* Upgrade Vite to v8 (#64600) * Upgrade Vite to v8 * Remove crypto.randomUUID polyfill * Remove tsconfigPathsPlugin from everywhere * pnpm format * Update electron vite config with new options * Fix the loading of ace editor * rollupOptions -> rolldownOptions in gen-event-reference-config * Import makeEvent directly to avoid including frontend code * Fix electron config * pnpm format * Ensure ace extensions load after ace is loaded * pnpm format * Change external dependencies to only apply to main/preload * Remove unused eslint directive * Add pnpm-lock * Update @swc/core and @swc/plugin-styled-components to match master * pnpm format * Remove `rolldown` dependency (#65330) (cherry picked from commit fc19088) * Remove HTTP2 headers * Upgrade vite to 8.0.7 --------- Co-authored-by: Grzegorz Zdunek <gzdunek@users.noreply.github.com>

* Upgrade Vite to v8 * Remove crypto.randomUUID polyfill * Remove tsconfigPathsPlugin from everywhere * pnpm format * Update electron vite config with new options * Fix the loading of ace editor * rollupOptions -> rolldownOptions in gen-event-reference-config * Import makeEvent directly to avoid including frontend code * Fix electron config * pnpm format * Ensure ace extensions load after ace is loaded * pnpm format * Change external dependencies to only apply to main/preload * Remove unused eslint directive

ryanclark requested review from avatus, gzdunek, r0mant, ravicious and zmb3 as code owners March 13, 2026 11:09

ryanclark added the no-changelog Indicates that a PR does not require a changelog entry label Mar 13, 2026

github-actions Bot added size/sm ui labels Mar 13, 2026

github-actions Bot requested a review from rudream March 13, 2026 11:09

chatgpt-codex-connector Bot reviewed Mar 13, 2026

View reviewed changes

Comment thread web/packages/shared/components/TextEditor/ace.js

gzdunek reviewed Mar 13, 2026

View reviewed changes

ryanclark marked this pull request as draft March 13, 2026 11:22

ryanclark force-pushed the ryan/vite8 branch 2 times, most recently from b6db2ac to 8fae01b Compare March 13, 2026 12:15

ryanclark marked this pull request as ready for review March 17, 2026 09:27

github-actions Bot requested a review from bl-nero March 17, 2026 09:28

ryanclark force-pushed the ryan/vite8 branch from cd315db to 9935bcc Compare March 17, 2026 09:28

chatgpt-codex-connector Bot reviewed Mar 17, 2026

View reviewed changes

Comment thread web/packages/teleterm/electron.vite.config.mts

avatus approved these changes Mar 17, 2026

View reviewed changes

ryanclark added 7 commits March 17, 2026 15:44

Upgrade Vite to v8

ab45f8b

Remove crypto.randomUUID polyfill

5431b7e

Remove tsconfigPathsPlugin from everywhere

0201695

pnpm format

4208937

Update electron vite config with new options

19d9400

Fix the loading of ace editor

c93d333

rollupOptions -> rolldownOptions in gen-event-reference-config

28c7ce3

ryanclark added 7 commits March 17, 2026 15:44

Import makeEvent directly to avoid including frontend code

e0f8c50

Fix electron config

35dc0ff

pnpm format

4ec86d7

Ensure ace extensions load after ace is loaded

249d494

pnpm format

59c74e6

Change external dependencies to only apply to main/preload

639d9db

Remove unused eslint directive

73ba262

ryanclark force-pushed the ryan/vite8 branch from 94e578c to 73ba262 Compare March 17, 2026 14:44

zmb3 approved these changes Mar 17, 2026

View reviewed changes

public-teleport-github-review-bot Bot removed request for bl-nero and rudream March 17, 2026 15:26

gzdunek approved these changes Mar 17, 2026

View reviewed changes

ryanclark added this pull request to the merge queue Mar 17, 2026

Merged via the queue into master with commit 7753fa0 Mar 17, 2026
45 checks passed

ryanclark deleted the ryan/vite8 branch March 17, 2026 16:28

ryanclark mentioned this pull request Mar 17, 2026

[v18] Upgrade Vite to v8 #64734

Merged

5 tasks

gzdunek mentioned this pull request Apr 2, 2026

Remove rolldown dependency #65330

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Vite to v8#64600

Upgrade Vite to v8#64600
ryanclark merged 14 commits intomasterfrom
ryan/vite8

ryanclark commented Mar 13, 2026 •

edited

Loading

Uh oh!

socket-security Bot commented Mar 13, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

gzdunek Mar 13, 2026

Uh oh!

ryanclark commented Mar 13, 2026 •

edited

Loading

Uh oh!

avatus commented Mar 13, 2026 •

edited

Loading

Uh oh!

avatus commented Mar 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

zmb3 left a comment

Uh oh!

gzdunek left a comment

Uh oh!

gzdunek Mar 17, 2026

Uh oh!

ryanclark Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ryanclark commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Manual Test Plan

Test Environment

Test Cases

Uh oh!

socket-security Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

gzdunek Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

ryanclark commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avatus commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avatus commented Mar 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

zmb3 left a comment

Choose a reason for hiding this comment

Uh oh!

gzdunek left a comment

Choose a reason for hiding this comment

Uh oh!

gzdunek Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

ryanclark Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ryanclark commented Mar 13, 2026 •

edited

Loading

socket-security Bot commented Mar 13, 2026 •

edited

Loading

ryanclark commented Mar 13, 2026 •

edited

Loading

avatus commented Mar 13, 2026 •

edited

Loading