[Web] Add polyfill for crypto.randomUUID#26368
Merged
Conversation
rudream
force-pushed
the
yassine/randomuuid
branch
2 times, most recently
from
6ec9594 to
896ef35
Compare
ravicious
reviewed
May 17, 2023
avatus
reviewed
May 17, 2023
avatus
approved these changes
May 17, 2023
Contributor
avatus
left a comment
avatus
left a comment
There was a problem hiding this comment.
preemptive approve once the few questions have been answered. neat stuff!
ravicious
approved these changes
May 19, 2023
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
Thanks for researching that question about the secure context.
Should we backport this all the way to v11 if needed?
public-teleport-github-review-bot
Bot
removed request for
gzdunek,
kimlisa,
ryanclark and
zmb3
rudream
force-pushed
the
yassine/randomuuid
branch
from
d375138 to
dc14f55
Compare
This was referenced May 19, 2023
rudream
added a commit
that referenced
this pull request
May 19, 2023
rudream
added a commit
that referenced
this pull request
May 25, 2023
ptgott
pushed a commit
that referenced
this pull request
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ecounterpart: https://github.com/gravitational/teleport.e/pull/1422Purpose
Adds a polyfill fallback for
crypto.randomUUIDfor old browsers that don't support it.Polyfill is from https://github.com/uuidjs/randomUUID
Tested with Firefox 91.0