Merged
Conversation
avatus
approved these changes
Apr 2, 2026
ryanclark
approved these changes
Apr 2, 2026
Member
ryanclark
left a comment
There was a problem hiding this comment.
Ah nice didn't know vite reexports it. Cheers
zmb3
approved these changes
Apr 2, 2026
Contributor
gzdunek
added a commit
that referenced
this pull request
Apr 3, 2026
ryanclark
pushed a commit
that referenced
this pull request
Apr 8, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
* Upgrade Vite to v8 (#64600) * Upgrade Vite to v8 * Remove crypto.randomUUID polyfill * Remove tsconfigPathsPlugin from everywhere * pnpm format * Update electron vite config with new options * Fix the loading of ace editor * rollupOptions -> rolldownOptions in gen-event-reference-config * Import makeEvent directly to avoid including frontend code * Fix electron config * pnpm format * Ensure ace extensions load after ace is loaded * pnpm format * Change external dependencies to only apply to main/preload * Remove unused eslint directive * Add pnpm-lock * Update @swc/core and @swc/plugin-styled-components to match master * pnpm format * Remove `rolldown` dependency (#65330) (cherry picked from commit fc19088) * Remove HTTP2 headers * Upgrade vite to 8.0.7 --------- Co-authored-by: Grzegorz Zdunek <gzdunek@users.noreply.github.com>
mmcallister
pushed a commit
that referenced
this pull request
Apr 24, 2026
mmcallister
pushed a commit
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was added in #64600, but I don't think we need it. It already comes via
vite, andRolldownOptionscan be imported fromvite.Manual Test Plan
Test Environment
Regular dev environment.
Test Cases