Skip to content

Remove rolldown dependency#65330

Merged
gzdunek merged 1 commit intomasterfrom
gzdunek/remove-rolldown-dependency
Apr 3, 2026
Merged

Remove rolldown dependency#65330
gzdunek merged 1 commit intomasterfrom
gzdunek/remove-rolldown-dependency

Conversation

@gzdunek
Copy link
Copy Markdown
Contributor

@gzdunek gzdunek commented Apr 2, 2026

It was added in #64600, but I don't think we need it. It already comes via vite, and RolldownOptions can be imported from vite.

Manual Test Plan

Test Environment

Regular dev environment.

Test Cases

  • pnpm build-ui-oss passes.

@gzdunek gzdunek requested a review from ryanclark April 2, 2026 15:20
@gzdunek gzdunek added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v18 labels Apr 2, 2026
@github-actions github-actions Bot requested a review from alexhemard April 2, 2026 15:21
Copy link
Copy Markdown
Member

@ryanclark ryanclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice didn't know vite reexports it. Cheers

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from alexhemard April 2, 2026 18:53
@gzdunek gzdunek added this pull request to the merge queue Apr 3, 2026
Merged via the queue into master with commit fc19088 Apr 3, 2026
56 checks passed
@gzdunek gzdunek deleted the gzdunek/remove-rolldown-dependency branch April 3, 2026 07:40
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@gzdunek See the table below for backport results.

Branch Result
branch/v18 Failed

gzdunek added a commit that referenced this pull request Apr 3, 2026
(cherry picked from commit fc19088)
ryanclark pushed a commit that referenced this pull request Apr 8, 2026
(cherry picked from commit fc19088)
github-merge-queue Bot pushed a commit that referenced this pull request Apr 8, 2026
* Upgrade Vite to v8 (#64600)

* Upgrade Vite to v8

* Remove crypto.randomUUID polyfill

* Remove tsconfigPathsPlugin from everywhere

* pnpm format

* Update electron vite config with new options

* Fix the loading of ace editor

* rollupOptions -> rolldownOptions in gen-event-reference-config

* Import makeEvent directly to avoid including frontend code

* Fix electron config

* pnpm format

* Ensure ace extensions load after ace is loaded

* pnpm format

* Change external dependencies to only apply to main/preload

* Remove unused eslint directive

* Add pnpm-lock

* Update @swc/core and @swc/plugin-styled-components to match master

* pnpm format

* Remove `rolldown` dependency (#65330)

(cherry picked from commit fc19088)

* Remove HTTP2 headers

* Upgrade vite to 8.0.7

---------

Co-authored-by: Grzegorz Zdunek <gzdunek@users.noreply.github.com>
mmcallister pushed a commit that referenced this pull request Apr 24, 2026
mmcallister pushed a commit that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v18 no-changelog Indicates that a PR does not require a changelog entry size/sm ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants