[v18] Implement Instance Inventory UI#62008
Conversation
|
@rudream - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
|
I suggest backporting the entire inventory cache and instance ui feature set to v18 in a single PR so that you can run a manual test plan again prior to merging the feature and so that we can be 100% confident that the entire feature lands at the same time so nothing is missing when this gets released. |
2989565 to
5718acc
Compare
InventoryCache to cache instancesThere was a problem hiding this comment.
Tested in a cloud tenant and looks good.
@rudream I noticed my tenant has a lot of proxy instances on the list. Some from the previous version and others on the current version. The deployment has 4 pods, two auth and two proxy.
$ kubectl -n cloud-gravitational-io-nicholasmarais1158 --context platform.teleport.sh-tc-staging-cs-01-euc1 get pods
NAME READY STATUS RESTARTS AGE
teleport-auth-bb9f9cf74-f8cpl 1/1 Running 0 35m
teleport-auth-bb9f9cf74-swj9n 1/1 Running 0 35m
teleport-proxy-57cfbcbbfc-rzrsv 1/1 Running 0 35m
teleport-proxy-57cfbcbbfc-sgd4g 1/1 Running 0 35m
Maybe it's because I just deployed and those extra instances will disappear later?
Screen.Recording.2026-01-14.at.17.26.46.mov
|
UI nit: Instance versions have a |
Thinking about this again, perhaps the extra proxy instances are running in other regions. This would explain why there are so many - the I think this is a non-issue. |
@espadolini @fspmarshall can you confirm if this is fine and expected or whether we should look into this further? Whatever the case may be, I don't think this would be a bug with the new Instance Inventory UI/Cache since it just pulls whatever is present in the backend. |
|
Very likely, but a |
Confirmed. There are 12 proxies in total, two in each of 6 regions. |
37461eb to
74ac1fb
Compare
|
Note that I've also added the changes from these PRs: |
74ac1fb to
1d7b132
Compare
788e7d4 to
d7d8eb8
Compare
dd5a0d4 to
4fbed65
Compare
4fbed65 to
e6a6a17
Compare
backports the following PR's to branch/v18:
InventoryCacheto cache instances #60535ecounterpart: https://github.com/gravitational/teleport.e/pull/7826Mostly clean backport, but had to use
"github.com/gravitational/teleport/lib/utils/testutils/synctest"instead oftesting/synctestsince it required go 1.25 (see this PR for context)Manual tests done:
older_than,newer_than,between), updater group, and external upgrader work as intended.readandlistpermissions forbot_instancebut notinstancelists bot instances only, with a warning banner at the top saying you are missinginstancepermissions.readandlistpermissions forinstancebut notbot_instancelists instances only, with a warning banner at the top saying you are missingbot_instancepermissions.readandlistpermissions for neitherbot_instanceorinstancedoes not list anything and just shows you the missing permissions banner.