Trim "v" prefix for all instance versions in inventory cache#63790
Merged
Trim "v" prefix for all instance versions in inventory cache#63790
Conversation
rudream
added
no-changelog
7 tasks
nicholasmarais1158
approved these changes
Feb 13, 2026
espadolini
approved these changes
Feb 13, 2026
public-teleport-github-review-bot
bot
removed the request for review
from Joerger
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
cthach
pushed a commit
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
There is an inconsistency in how we store versions for resources. In some cases, they will have a
"v"prefix (eg. "v18.0.0"), and in other cases not (such as for bot instances). Thevprefix is added by this function, however there are paths that never invoke it and thus may result in storing a resource with no version prefix in its version field.This inconsistency means that the Instance Inventory UI version filtering may not work properly, if you have some instances with prefixes and others without, you'd have to run something like
version == "18.0.0" || version == "v18.0.0"in order to get all of them in a single query.This PR normalizes all instance versions in the inventory cache to have no prefix in order to prevent this and make filtering consistent.