Fix filtering instances by no upgrader in instance inventory#63184
Merged
Fix filtering instances by no upgrader in instance inventory#63184
Conversation
rudream
added
no-changelog
github-actions
bot
requested review from
fspmarshall,
ravicious and
tele-lion
avatus
approved these changes
Jan 27, 2026
avatus
reviewed
Jan 27, 2026
Comment on lines
+92
to
+98
| // We don't use splitQuery for parsing upgraders since it should be possible to filter for upgrader "" (none), | ||
| // and splitQuery would remove it. | ||
| var upgraders []string | ||
| if upgradersParam := values.Get("upgraders"); upgradersParam != "" { | ||
| upgraders = strings.Split(upgradersParam, ",") | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
this has been a gotcha in a few other places (like kinds in unified resource requests)
ravicious
approved these changes
Jan 27, 2026
Contributor
rudream
added a commit
that referenced
this pull request
Jan 29, 2026
7 tasks
cthach
pushed a commit
that referenced
this pull request
Jan 29, 2026
rudream
added a commit
that referenced
this pull request
Feb 13, 2026
rudream
added a commit
that referenced
this pull request
Feb 13, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
* implement instance inventory UI * fix filtering by no upgrader (#63184) * add prometheus metrics to inventory cache * trim v prefix for all instance versions in inventory cache * use accesslistservicev2 and static scoped service in test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a regression causing the "None" option for filtering by upgraders in the instance inventory not to work. This was likely introduced when implementing a suggestion to use
splitQueryto handle params in the API handler, which trims empty strings from the query.