Skip to content

[api] Add ListDatabases#57805

Merged
okraport merged 1 commit intomasterfrom
okraport/paginate-getdatabases
Aug 19, 2025
Merged

[api] Add ListDatabases#57805
okraport merged 1 commit intomasterfrom
okraport/paginate-getdatabases

Conversation

@okraport
Copy link
Copy Markdown
Contributor

@okraport okraport commented Aug 12, 2025

This commits deperecates GetDatabases, which
should be replaced by a paginated counterpart:
ListDatabases

The commit also adds useful itertools/stream helper:

  • TakeWhile

Towards: gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListDatabases, deprecate GetDatabases

@okraport okraport force-pushed the okraport/paginate-getdatabases branch 3 times, most recently from 4fcde7b to d28e69d Compare August 12, 2025 12:32
@okraport okraport marked this pull request as ready for review August 12, 2025 12:34
@github-actions github-actions bot added discovery size/lg tctl tctl - Teleport admin tool labels Aug 12, 2025
Comment thread lib/auth/auth_with_roles.go Outdated
@okraport okraport requested a review from fspmarshall August 12, 2025 12:50
@okraport
Copy link
Copy Markdown
Contributor Author

@fspmarshall would appreciate your eyes for itertools please 🙏

@okraport okraport force-pushed the okraport/paginate-getdatabases branch from d28e69d to 825f71f Compare August 12, 2025 13:11
@rosstimothy rosstimothy removed the request for review from fheinecke August 12, 2025 13:18
Comment thread lib/cache/database.go Outdated
Comment thread api/client/client.go
Comment thread lib/itertools/stream/stream.go Outdated
Comment thread lib/itertools/stream/stream.go Outdated
Comment thread lib/itertools/stream/stream.go Outdated
Comment thread lib/itertools/stream/stream.go Outdated
@okraport okraport force-pushed the okraport/paginate-getdatabases branch 2 times, most recently from d124048 to 27be872 Compare August 13, 2025 09:14
@okraport
Copy link
Copy Markdown
Contributor Author

Rebased and fixed proto conflicts.

@okraport okraport force-pushed the okraport/paginate-getdatabases branch from a72bd5b to 68ac05b Compare August 13, 2025 11:03
Comment thread lib/cache/database_test.go Outdated
Comment thread lib/services/local/databases_test.go Outdated
Comment thread lib/srv/discovery/discovery_eks_test.go
@okraport okraport force-pushed the okraport/paginate-getdatabases branch from 4a2c4ae to f8a14eb Compare August 19, 2025 09:28
@okraport
Copy link
Copy Markdown
Contributor Author

Rebased + squashed

@okraport okraport enabled auto-merge August 19, 2025 09:32
This commits deperecates GetDatabases, which
should be replaced by a paginated counterpart:
ListDatabases

The commit also adds TakeWhile for conditional
iter stream reads.

Towards: gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListDatabases, deprecate GetDatabases
@okraport okraport force-pushed the okraport/paginate-getdatabases branch from f8a14eb to 39f5ded Compare August 19, 2025 09:42
@okraport okraport added this pull request to the merge queue Aug 19, 2025
Merged via the queue into master with commit f04493e Aug 19, 2025
43 checks passed
@okraport okraport deleted the okraport/paginate-getdatabases branch August 19, 2025 10:28
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@okraport See the table below for backport results.

Branch Result
branch/v16 Failed
branch/v17 Failed
branch/v18 Failed

okraport added a commit that referenced this pull request Aug 19, 2025
This commits deperecates GetDatabases, which
should be replaced by a paginated counterpart:
ListDatabases

The commit also adds TakeWhile for conditional
iter stream reads.

Regenerated protos with `make grpc` for backport.

Towards: gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListDatabases, deprecate GetDatabases
ryanclark pushed a commit that referenced this pull request Aug 19, 2025
This commits deperecates GetDatabases, which
should be replaced by a paginated counterpart:
ListDatabases

The commit also adds TakeWhile for conditional
iter stream reads.

Towards: gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListDatabases, deprecate GetDatabases
ryanclark pushed a commit that referenced this pull request Aug 19, 2025
This commits deperecates GetDatabases, which
should be replaced by a paginated counterpart:
ListDatabases

The commit also adds TakeWhile for conditional
iter stream reads.

Towards: gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListDatabases, deprecate GetDatabases
okraport added a commit that referenced this pull request Aug 21, 2025
This commits deperecates GetDatabases, which
should be replaced by a paginated counterpart:
ListDatabases

The commit also adds TakeWhile for conditional
iter stream reads.

Regenerated protos with `make grpc` for backport.

Towards: gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListDatabases, deprecate GetDatabases
okraport added a commit that referenced this pull request Aug 27, 2025
This commits deperecates GetDatabases, which
should be replaced by a paginated counterpart:
ListDatabases

The commit also adds TakeWhile for conditional
iter stream reads.

Regenerated protos with `make grpc` for backport.

Towards: gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListDatabases, deprecate GetDatabases
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2025
This commits deperecates GetDatabases, which
should be replaced by a paginated counterpart:
ListDatabases

The commit also adds TakeWhile for conditional
iter stream reads.

Regenerated protos with `make grpc` for backport.

Towards: gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListDatabases, deprecate GetDatabases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants