Skip to content

[v18] [api] Add ListDatabases#58105

Merged
okraport merged 1 commit intobranch/v18from
okraport/backport-57805-branch/v18
Aug 27, 2025
Merged

[v18] [api] Add ListDatabases#58105
okraport merged 1 commit intobranch/v18from
okraport/backport-57805-branch/v18

Conversation

@okraport
Copy link
Copy Markdown
Contributor

Backport #57805 to branch/v18
Regenerated protos with make grpc for backport.

Changelog: Add paginated API ListDatabases, deprecate GetDatabases

@okraport okraport marked this pull request as ready for review August 20, 2025 10:54
@github-actions github-actions bot added backport discovery size/lg tctl tctl - Teleport admin tool labels Aug 20, 2025
Comment thread api/proto/teleport/legacy/client/proto/authservice.proto Outdated
Comment thread api/client/client.go Outdated
@okraport okraport marked this pull request as draft August 20, 2025 13:09
@okraport okraport force-pushed the okraport/backport-57805-branch/v18 branch from 3601781 to f55406f Compare August 21, 2025 13:18
@okraport okraport marked this pull request as ready for review August 21, 2025 13:18
@github-actions github-actions bot requested a review from rosstimothy August 21, 2025 13:19
@okraport
Copy link
Copy Markdown
Contributor Author

This is ready for a stamp, @fspmarshall could you have a look please?

@rosstimothy rosstimothy requested a review from zmb3 August 27, 2025 15:05
This commits deperecates GetDatabases, which
should be replaced by a paginated counterpart:
ListDatabases

The commit also adds TakeWhile for conditional
iter stream reads.

Regenerated protos with `make grpc` for backport.

Towards: gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListDatabases, deprecate GetDatabases
@okraport okraport force-pushed the okraport/backport-57805-branch/v18 branch from f55406f to 9299142 Compare August 27, 2025 15:32
@okraport
Copy link
Copy Markdown
Contributor Author

Rebased to resolve conflicts.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from fspmarshall August 27, 2025 15:32
@okraport okraport added this pull request to the merge queue Aug 27, 2025
Merged via the queue into branch/v18 with commit 3796104 Aug 27, 2025
43 checks passed
@okraport okraport deleted the okraport/backport-57805-branch/v18 branch August 27, 2025 16:21
@doggydogworld doggydogworld mentioned this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport discovery size/lg tctl tctl - Teleport admin tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants