Merged
Conversation
Contributor
Author
|
Putting this on draft to wait for #57861 |
Contributor
Author
The |
This commits deperecates GetDatabases, which should be replaced by a paginated counterpart: ListDatabases The commit also adds TakeWhile for conditional iter stream reads. Note that this backport, does not include the `Range*` helpers as those are not supported in go1.23. Towards: gravitational/teleport.e/issues/6759 Changelog: Add paginated API ListDatabases, deprecate GetDatabases
okraport
force-pushed
the
okraport/backport-57805-branch/v16
branch
from
2b3d446 to
42413a6
Compare
rosstimothy
approved these changes
Aug 21, 2025
Contributor
Author
|
This is ready for a stamp, @fspmarshall could you have a look please? |
zmb3
approved these changes
Aug 27, 2025
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #57805 to branch/v16
Regenerated protos with make grpc for backport.
Note that this backport, does not include the
Range* helpers as those are not supported in go1.23.
Changelog: Add paginated API ListDatabases, deprecate GetDatabases