Don't omit CDP info for PKINIT certificates#56849
Merged
Conversation
github-actions
bot
added
database-access
zmb3
approved these changes
Jul 16, 2025
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
greedy52
approved these changes
Jul 16, 2025
public-teleport-github-review-bot
bot
removed the request for review
from rudream
Contributor
This was referenced Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on the configuration, the CDP information may be required, so we shouldn't omit this. The change to omit CDP is very recent and didn't cause problems during tests, but some problems were reported later, so this PR changes this back.
Related to:
changelog: Improve PKINIT compatibility by always including CDP information in the certificate