Skip to content

Don't omit CDP info for PKINIT certificates #56849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tener merged 3 commits into from
Jul 16, 2025
Merged

Don't omit CDP info for PKINIT certificates #56849

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed1fda0
Don't omit CDP info for PKINIT certificates
Tener Jul 16, 2025
01b70d8
Update lib/srv/db/common/kerberos/kinit/ldap.go
Tener Jul 16, 2025
9b9e02e
Merge branch 'master' into tener/kinit-omitcdp
Tener Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/srv/db/common/kerberos/kinit/ldap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func (s *ldapConnector) tlsConfigForLDAP(ctx context.Context, clusterName string
ClusterName: clusterName,
Domain: s.ldapConfig.domain,
ActiveDirectorySID: s.ldapConfig.serviceAccountSID,
OmitCDP: true,
OmitCDP: false,
Comment thread
Tener marked this conversation as resolved.
Outdated
}

certPEM, keyPEM, caCerts, err := winpki.DatabaseCredentials(ctx, s.authClient, req)
Expand Down
Loading