Skip to content

Remove OmitCDP flag for db certs in PKINIT flow#57802

Merged
Tener merged 2 commits intomasterfrom
tener/fix-omitcdp
Aug 13, 2025
Merged

Remove OmitCDP flag for db certs in PKINIT flow#57802
Tener merged 2 commits intomasterfrom
tener/fix-omitcdp

Conversation

@Tener
Copy link
Copy Markdown
Contributor

@Tener Tener commented Aug 12, 2025

Remove an instance of OmitCDP amending the PKINIT flow fix:

changelog: Fix database PKINIT issues caused missing CDP information in the certificate

Copy link
Copy Markdown
Contributor

@greedy52 greedy52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@greedy52
Copy link
Copy Markdown
Contributor

Is it possible to add a regression test for this?

@Tener
Copy link
Copy Markdown
Contributor Author

Tener commented Aug 13, 2025

Is it possible to add a regression test for this?

Good point.

I've added a check for this to TestTLSConfigForLDAP, which verifies the call site modified in #56849.

I've also added an entirely new test TestGetCertificate (based on TestTLSConfigForLDAP), which covers the call site from this PR.

@Tener Tener enabled auto-merge August 13, 2025 11:28
@Tener Tener added this pull request to the merge queue Aug 13, 2025
Merged via the queue into master with commit 4d56022 Aug 13, 2025
40 of 42 checks passed
@Tener Tener deleted the tener/fix-omitcdp branch August 13, 2025 12:22
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@Tener See the table below for backport results.

Branch Result
branch/v17 Failed
branch/v18 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants