[v17] Update second_factors docs for v16 compatibility issue#54909
Merged
Joerger merged 2 commits intobranch/v17from May 21, 2025
Merged
[v17] Update second_factors docs for v16 compatibility issue#54909Joerger merged 2 commits intobranch/v17from
second_factors docs for v16 compatibility issue#54909Joerger merged 2 commits intobranch/v17from
Conversation
…ault preferred value in docs.
Joerger
added
the
no-changelog
Contributor
|
Amplify deployment status
|
espadolini
approved these changes
May 19, 2025
| // 1 is "otp", 2 is "webauthn", 3 is "sso", | ||
| // If unspecified, the current default value is [1], or ["otp"]. | ||
| // | ||
| // WARNING: only set SecondFactors if your cluster is fully upgraded to v17+. |
Contributor
There was a problem hiding this comment.
Suggested change
| // WARNING: only set SecondFactors if your cluster is fully upgraded to v17+. | |
| // WARNING: only set second_factors if your cluster is fully upgraded to v17+. |
Contributor
Author
There was a problem hiding this comment.
Upper camel case is intentional here
Contributor
There was a problem hiding this comment.
This ends up populating user facing documentation in the terraform docs tho.
Contributor
Author
There was a problem hiding this comment.
I see how that is awkward, but if anything that points to this type of docs generation being non-ideal. We would need to change line 2296 as well to get the right output for terraform docs:
second_factors(List of Number) SecondFactors is a list of supported multi-factor types...
marcoandredinis
approved these changes
May 19, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from hugoShaka
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
hugoShaka
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs followup to #54735
Like its predecessor, this PR is straight for v17.