[v17] Use second_factor in the v17 teleport-cluster chart#54735
Merged
espadolini merged 1 commit intobranch/v17from May 13, 2025
Merged
[v17] Use second_factor in the v17 teleport-cluster chart#54735espadolini merged 1 commit intobranch/v17from
second_factor in the v17 teleport-cluster chart#54735espadolini merged 1 commit intobranch/v17from
Conversation
Contributor
|
Amplify deployment status
|
hugoShaka
approved these changes
May 12, 2025
Contributor
|
Can we also update the |
Contributor
Author
@Joerger said he's gonna address the docs around |
marcoandredinis
approved these changes
May 13, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
second_factorsfield in thecluster-auth-preferenceof a v17 cluster that still has v16 agents or clients can result in widespread problems due to our overly strict checks in(*AuthPreferenceV2).CheckAndSetDefaults. This PR reverts the change in default values in theteleport-clusterchart done in #53319, since the problem can be avoided just by not using the new field in favor of the old one.This PR is straight for v17 since v18 will only have to deal with v17+ clients which will all support the new field correctly.
changelog: reverted the default behavior of the
teleport-clusterHelm chart to useauthentication.secondFactorrather thanauthentication.secondFactorsto avoid incompatibility during upgrades