Propagate username updates in tsh #5323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
requested review from
a-palchikov,
awly,
klizhentas,
r0mant,
russjones and
webvictim
as code owners
r0mant
approved these changes
Jan 16, 2021
tool/tsh/tsh.go
Outdated
| @@ -610,6 +610,10 @@ func onLogin(cf *CLIConf) { | |||
| utils.FatalError(err) | |||
| } | |||
|
|
|||
| // the login operation may update the username and should be considered the more | |||
| // "authoratative" source. | |||
fspmarshall
force-pushed
the
fspmarshall/fix-username-prop
branch
from
9b066b7 to
de36e89
Compare
This was referenced Jan 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tshwas sometimes using the incorrect username when generating access requests from a fresh state (i.e. if no~/.tshpreviously existed). This is because some login methods (e.g.oidc) update the username, but the updated username was not being propagated back up totsh's top-level configuration.Fixes #5316