Improve tsh tests #5394
Merged
Improve tsh tests #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
requested review from
a-palchikov,
awly,
klizhentas,
r0mant,
russjones and
webvictim
as code owners
fspmarshall
force-pushed
the
fspmarshall/test-tsh-oidc
branch
from
ee725f4 to
544c129
Compare
a-palchikov
reviewed
Jan 25, 2021
| utils.InitLoggerForTests(testing.Verbose()) | ||
| os.RemoveAll(client.FullProfilePath("")) | ||
|
|
||
| defer os.RemoveAll(client.FullProfilePath("")) |
There was a problem hiding this comment.
I found the the removal of the default tsh login extremely hideous when working with the external environments (after a successful tsh login) and with (unit) tests - I think we should make an effort with replacing this with a temporary location as is otherwise customary for testing. WDYT?
There was a problem hiding this comment.
I agree, but currently tsh behavior does not allow custom profile paths. It should, but, since the clearing behavior predates this PR, I'd prefer to add that functionality as a separate PR with a decent amount of manual testing to ensure no regressions.
awly
reviewed
Jan 26, 2021
fspmarshall
force-pushed
the
fspmarshall/test-tsh-oidc
branch
from
544c129 to
b0b0a29
Compare
fspmarshall
force-pushed
the
fspmarshall/test-tsh-oidc
branch
from
b0b0a29 to
08ff453
Compare
awly
approved these changes
Feb 9, 2021
fspmarshall
force-pushed
the
fspmarshall/test-tsh-oidc
branch
from
08ff453 to
46356e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to tests/testability for
tsh, including coverage for #5323