Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport & Release 4.4.7 #5329

Merged
merged 3 commits into from
Jan 18, 2021

Conversation

fspmarshall
Copy link
Contributor

Backports #5226 and #5323 and sets up Release 4.4.7.

Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand you're doing this to fix an immediate customer issue, please wrap around next week to add test coverage to the fixes.

CHANGELOG.md Outdated
This release of Teleport contains multiple bug fixes.

* Fixed an issue where the `request_access: reason` role option was triggering
the reason dialogue when opening new tabs/windows in firefox.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the reason dialogue when opening new tabs/windows in firefox.
the reason dialogue when opening new tabs/windows in Firefox.

@webvictim
Copy link
Contributor

I found this related issue - #5137

Not sure whether this will need to be done before 4.4.7 can go out @fspmarshall @klizhentas

@fspmarshall fspmarshall force-pushed the fspmarshall/backport-and-release-4.4.7 branch from 48d924c to 1783ca1 Compare January 18, 2021 17:43
@fspmarshall
Copy link
Contributor Author

@webvictim Given that these are time-sensitive bug fixes and that issue appears to be a request for additional functionality not currently present in 4.4, I'm gonna bump it ot 4.4.8.

@fspmarshall fspmarshall merged commit 19cca22 into branch/4.4 Jan 18, 2021
@fspmarshall fspmarshall deleted the fspmarshall/backport-and-release-4.4.7 branch January 18, 2021 18:02
@fspmarshall fspmarshall restored the fspmarshall/backport-and-release-4.4.7 branch January 18, 2021 18:02
@zmb3 zmb3 deleted the fspmarshall/backport-and-release-4.4.7 branch April 26, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants