Skip to content

GitHub proxy part 4: tsh git ls with unified resource#49596

Merged
greedy52 merged 5 commits intomasterfrom
STeve/48762_git_server_cache_unified_resource
Dec 5, 2024
Merged

GitHub proxy part 4: tsh git ls with unified resource#49596
greedy52 merged 5 commits intomasterfrom
STeve/48762_git_server_cache_unified_resource

Conversation

@greedy52
Copy link
Copy Markdown
Contributor

@greedy52 greedy52 commented Nov 29, 2024 •
edited
Loading

related:

sample output:

$ tsh git ls
Type   Organization         Username URL                                     
------ -------------------- -------- --------------------------------------- 
GitHub goteleport-core-test (n/a)*   https://github.com/goteleport-core-test 

(n/a)*: Username will be retrieved automatically upon running git commands.
        Alternatively, run `tsh git login --github-org <org>`.

hint: use 'tsh git clone <git-clone-ssh-url>' to clone a new repository
      use 'tsh git config update' to configure an existing repository to use Teleport
      once the repository is cloned or configured, use 'git' as normal

@greedy52 greedy52 added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Nov 29, 2024
@greedy52 greedy52 requested a review from r0mant November 29, 2024 19:39
@greedy52 greedy52 self-assigned this Nov 29, 2024
@greedy52 greedy52 mentioned this pull request Nov 29, 2024
Closed
9 tasks
@github-actions github-actions Bot added size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Nov 29, 2024
@github-actions github-actions Bot requested review from avatus and fheinecke November 29, 2024 19:40
zmb3
zmb3 reviewed Nov 29, 2024
View reviewed changes
Comment thread api/types/resource.go Outdated
@greedy52 greedy52 mentioned this pull request Dec 2, 2024
Merged
r0mant
r0mant approved these changes Dec 3, 2024
View reviewed changes
Comment thread tool/tsh/common/git_list.go Outdated
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from fheinecke December 4, 2024 15:18
Base automatically changed from STeve/48762_git_server_cache to master December 5, 2024 03:38
@greedy52 greedy52 force-pushed the STeve/48762_git_server_cache_unified_resource branch from d1e8553 to 982bf3d Compare December 5, 2024 03:55
@greedy52 greedy52 enabled auto-merge December 5, 2024 16:38
@greedy52 greedy52 force-pushed the STeve/48762_git_server_cache_unified_resource branch from baba4f7 to cac2a5a Compare December 5, 2024 17:00
@greedy52 greedy52 added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024
@greedy52 greedy52 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into master with commit 8f50cf1 Dec 5, 2024
@greedy52 greedy52 deleted the STeve/48762_git_server_cache_unified_resource branch December 5, 2024 17:58
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Dec 5, 2024

@greedy52 See the table below for backport results.

Branch Result
branch/v17 Failed

greedy52 added a commit that referenced this pull request Jan 15, 2025
@greedy52
GitHub proxy part 4: tsh git ls with unified resource (#49596)
7f70cf3 
* GitHub proxy part 4: tsh git ls

* fix ut

* update username note

* fix
greedy52 added a commit that referenced this pull request Jan 16, 2025
@greedy52
GitHub proxy part 4: tsh git ls with unified resource (#49596)
66d4a8c 
* GitHub proxy part 4: tsh git ls

* fix ut

* update username note

* fix
github-merge-queue Bot pushed a commit that referenced this pull request Jan 16, 2025
@greedy52
[v17] GitHub proxy (#51086)
7ca4e53 
* GitHub Proxy part 1: github integration resource (#48999)

* github integration resource

* fix lib/web

* revert withSecrets

* use static credentials

* address review comments

* fix ut

* GitHub Proxy part 2: git_server resource, service, and RBAC (#49393)

* git_server resource and role.allow.github_permissions

* implicit RO on KindGitServer

* review comments

* fix ut

* make -C integrations/operator crd

* fix ut again

* make crds-up-to-date and make -C integrations/terraform docs

* GitHub proxy part 1.5: integration in web ui (#49561)

* GitHub proxy part 1.5: integration in web ui

* fix lint

* GitHub Proxy part 3.5: caching PluginStaticCredentials (#49472)

* GitHub Proxy part 3.5: caching PluginStaticCredentials

* fix lint

* GitHub proxy part 2.5: git_server cache (#49564)

* GitHub proxy part 2.5: git_server cache

* revert event

* fix getAll

* review comments

* GitHub Proxy part 3: gen github user cert and export CA (#49396)

* GitHub Proxy part 3: gen github user cert and export CA

* address pr comment

* minor refactor

* use cache

* fix build and cache

* GitHub proxy part 4: `tsh git ls` with unified resource (#49596)

* GitHub proxy part 4: tsh git ls

* fix ut

* update username note

* fix

* GitHub proxy part 5: OAuth flow to retrieve GitHub identity (#49849)

* GitHub proxy part 5: OAuth flow to retrieve GitHub identity

* review comments round1

* review comments round 2 and update tsh git list

* make -C integrations/operator crd

* make -C integrations/terraform docs

* fix flaky test

* GitHub proxy part 6.5: tsh git ssh/clone/config (#50044)

* GitHub proxy part 6.5: tsh git ssh/clone/config

* review comments

* fix test

* fix ut for lookpath

* fix logger and update dependency version

* go mod tidy for integrations

* GitHub proxy part 7: audit events (#49923)

* GitHub proxy part 7: audit events

* make Git Command consistent

* fix typo

* GitHub proxy: git command recorder (#50505)

* GitHub proxy: recording git command

* address review

* review comments

* allow flags after repository for git-upload-pack

* GitHub proxy part 6: proxing Git using SSH transport (#49980)

* GitHub proxy part 6: proxing Git using SSH transport

* better command parsing and update suite

* refactor

* revert unnecearrty files

* address review comments

* ut fix

* revert localsite_test.go

* change special suffix to teleport-github-org for routing

* fix routing ut

* minor typo edit

* fix ut after sshca change

* add UT to sshutils

* minor review comments

* fix api ut because of special suffix change

* GitServerReadOnlyClient

* downgrade error to warning

* run go mod tidy. not sure why it's needed

* rename mock.go to mock_test.go

* GitHub Proxy: complete audit event flow and add an enterprise guard (#51049)

* fix lint and remove accidently checked-in binary

* Fix flaky git.TestForwardServer test (#51112)
carloscastrojumo pushed a commit to carloscastrojumo/teleport that referenced this pull request Feb 19, 2025
@greedy52 @carloscastrojumo
GitHub proxy part 4: tsh git ls with unified resource (gravitationa…
8581e61 
…l#49596)

* GitHub proxy part 4: tsh git ls

* fix ut

* update username note

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmb3 zmb3 zmb3 left review comments

@r0mant r0mant r0mant approved these changes

@avatus avatus avatus approved these changes

Assignees

@greedy52 greedy52

Labels

backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@greedy52 @r0mant @avatus @zmb3