Skip to content

GitHub Proxy part 3: gen github user cert and export CA#49396

Merged
greedy52 merged 7 commits intomasterfrom
STeve/48762_gen_cert
Dec 3, 2024
Merged

GitHub Proxy part 3: gen github user cert and export CA#49396
greedy52 merged 7 commits intomasterfrom
STeve/48762_gen_cert

Conversation

@greedy52
Copy link
Copy Markdown
Contributor

@greedy52 greedy52 commented Nov 25, 2024

part of:

Changes:

  • Added GenerateGitHubUserCert API according to GitHub spec
  • Added ExportIntegrationCertAuthorities and tctl auth export --type github --integration my-ig

@greedy52 greedy52 force-pushed the STeve/48762_gen_cert branch from c2a8bde to 8a37884 Compare November 25, 2024 02:59
@greedy52 greedy52 force-pushed the STeve/48762_gen_cert branch from 8a37884 to ea37165 Compare November 25, 2024 17:06
@greedy52 greedy52 added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Nov 25, 2024
@greedy52 greedy52 marked this pull request as ready for review November 25, 2024 17:13
@github-actions github-actions Bot added size/lg tctl tctl - Teleport admin tool labels Nov 25, 2024
Comment thread lib/auth/integration/integrationv1/github.go Outdated
Comment thread lib/auth/integration/integrationv1/github.go Outdated
Comment thread api/proto/teleport/integration/v1/integration_service.proto Outdated
Comment thread lib/auth/integration/integrationv1/credentials_test.go Outdated
@greedy52 greedy52 mentioned this pull request Nov 28, 2024
9 tasks
@greedy52 greedy52 added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@greedy52 greedy52 added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@greedy52 greedy52 added this pull request to the merge queue Dec 3, 2024
Merged via the queue into master with commit 903fee0 Dec 3, 2024
@greedy52 greedy52 deleted the STeve/48762_gen_cert branch December 3, 2024 18:36
@public-teleport-github-review-bot
Copy link
Copy Markdown

@greedy52 See the table below for backport results.

Branch Result
branch/v17 Failed

greedy52 added a commit that referenced this pull request Jan 15, 2025
* GitHub Proxy part 3: gen github user cert and export CA

* address pr comment

* minor refactor

* use cache

* fix build and cache
greedy52 added a commit that referenced this pull request Jan 16, 2025
* GitHub Proxy part 3: gen github user cert and export CA

* address pr comment

* minor refactor

* use cache

* fix build and cache
github-merge-queue Bot pushed a commit that referenced this pull request Jan 16, 2025
* GitHub Proxy part 1: github integration resource (#48999)

* github integration resource

* fix lib/web

* revert withSecrets

* use static credentials

* address review comments

* fix ut

* GitHub Proxy part 2: git_server resource, service, and RBAC (#49393)

* git_server resource and role.allow.github_permissions

* implicit RO on KindGitServer

* review comments

* fix ut

* make -C integrations/operator crd

* fix ut again

* make crds-up-to-date and make -C integrations/terraform docs

* GitHub proxy part 1.5: integration in web ui (#49561)

* GitHub proxy part 1.5: integration in web ui

* fix lint

* GitHub Proxy part 3.5: caching PluginStaticCredentials (#49472)

* GitHub Proxy part 3.5: caching PluginStaticCredentials

* fix lint

* GitHub proxy part 2.5: git_server cache (#49564)

* GitHub proxy part 2.5: git_server cache

* revert event

* fix getAll

* review comments

* GitHub Proxy part 3: gen github user cert and export CA (#49396)

* GitHub Proxy part 3: gen github user cert and export CA

* address pr comment

* minor refactor

* use cache

* fix build and cache

* GitHub proxy part 4: `tsh git ls` with unified resource (#49596)

* GitHub proxy part 4: tsh git ls

* fix ut

* update username note

* fix

* GitHub proxy part 5: OAuth flow to retrieve GitHub identity (#49849)

* GitHub proxy part 5: OAuth flow to retrieve GitHub identity

* review comments round1

* review comments round 2 and update tsh git list

* make -C integrations/operator crd

* make -C integrations/terraform docs

* fix flaky test

* GitHub proxy part 6.5: tsh git ssh/clone/config (#50044)

* GitHub proxy part 6.5: tsh git ssh/clone/config

* review comments

* fix test

* fix ut for lookpath

* fix logger and update dependency version

* go mod tidy for integrations

* GitHub proxy part 7: audit events (#49923)

* GitHub proxy part 7: audit events

* make Git Command consistent

* fix typo

* GitHub proxy: git command recorder (#50505)

* GitHub proxy: recording git command

* address review

* review comments

* allow flags after repository for git-upload-pack

* GitHub proxy part 6: proxing Git using SSH transport (#49980)

* GitHub proxy part 6: proxing Git using SSH transport

* better command parsing and update suite

* refactor

* revert unnecearrty files

* address review comments

* ut fix

* revert localsite_test.go

* change special suffix to teleport-github-org for routing

* fix routing ut

* minor typo edit

* fix ut after sshca change

* add UT to sshutils

* minor review comments

* fix api ut because of special suffix change

* GitServerReadOnlyClient

* downgrade error to warning

* run go mod tidy. not sure why it's needed

* rename mock.go to mock_test.go

* GitHub Proxy: complete audit event flow and add an enterprise guard (#51049)

* fix lint and remove accidently checked-in binary

* Fix flaky git.TestForwardServer test (#51112)
carloscastrojumo pushed a commit to carloscastrojumo/teleport that referenced this pull request Feb 19, 2025
…l#49396)

* GitHub Proxy part 3: gen github user cert and export CA

* address pr comment

* minor refactor

* use cache

* fix build and cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/lg tctl tctl - Teleport admin tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants