GitHub proxy part 4.5: git server in UI#49644
Merged
Conversation
greedy52
added
no-changelog
greedy52
force-pushed
the
STeve/48762_git_server_cache_unified_resource
branch
from
d1e8553 to
982bf3d
Compare
Base automatically changed from
STeve/48762_git_server_cache_unified_resource
to
master
December 5, 2024 17:58
greedy52
force-pushed
the
STeve/48762_git_server_cache_unified_resource_ui
branch
7 times, most recently
from
fb9aeb1 to
acaca65
Compare
Contributor
|
I didn't get a chance to check this out today but i will look at it the first thing in the morning tomorrow |
gzdunek
reviewed
Dec 10, 2024
Comment on lines
+338
to
+340
| const organization = gitserver.github | ||
| ? gitserver.github.organization | ||
| : undefined; |
Contributor
There was a problem hiding this comment.
Suggested change
| const organization = gitserver.github | |
| ? gitserver.github.organization | |
| : undefined; | |
| const organization = gitserver.github?.organization; |
avatus
reviewed
Dec 10, 2024
greedy52
force-pushed
the
STeve/48762_git_server_cache_unified_resource_ui
branch
from
acaca65 to
8cf6b5a
Compare
Contributor
Author
gzdunek
approved these changes
Jan 21, 2025
avatus
approved these changes
Jan 21, 2025
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
* GitHub proxy part 4.5: git server in UI * review comments * fix storybook * then -> and then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
tsh git lswith unified resource #49596e:
(note, this PR is optional for the initial MVP release but very nice to have)
Storybook screenshots:
