Install the expected protoc-gen-terraform version in lint.yaml#47268
Merged
espadolini merged 1 commit intomasterfrom Oct 7, 2024
Merged
Install the expected protoc-gen-terraform version in lint.yaml#47268espadolini merged 1 commit intomasterfrom
protoc-gen-terraform version in lint.yaml#47268espadolini merged 1 commit intomasterfrom
Conversation
espadolini
added
the
no-changelog
espadolini
requested review from
camscale,
codingllama,
fheinecke,
klizhentas,
r0mant,
rosstimothy,
russjones,
tcsc and
zmb3
as code owners
rosstimothy
approved these changes
Oct 7, 2024
tigrato
approved these changes
Oct 7, 2024
public-teleport-github-review-bot
Bot
removed request for
bernardjkim,
eriktate,
hugoShaka and
strideynet
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
hugoShaka
approved these changes
Oct 7, 2024
|
@espadolini See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lint.yamlworkflow installs the tip of themainbranch from thegravitational/protoc-gen-terraformrepository, while thegen-tfschematarget inintegrations/terraform/Makefileexpects a fixed version. Sinceprotoc-gen-terraformv3.0.0 seems to have broken codegen at the current time, and the version check prevents merging any PR that touches a proto file or ago.modfile, this PR changes the workflow to install the exact version that theMakefileexpects.For verification, the commit referenced in
lint.yamlis gravitational/protoc-gen-terraform@0876826 .