Update protoc-gen-terraform to v3.0.0#47374
Conversation
configs to support using protoc-gen-terraform v3.0.0
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
github-actions
Bot
requested review from
bernardjkim,
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
tigrato,
xinding33 and
zmb3
|
🤖 Vercel preview here: https://docs-1bjssv8pq-goteleport.vercel.app/docs/ver/preview |
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
LGTM and thank you so much for improving the provider and its documentation.
The prose linter is failing but you can ignore it. Don't rewrite every proto message.
The Go Linter is failing because it cannot install the correct version. Would you mind updating the protoc-gen-tfschema ref in the CI job? Edoardo pinned it in #47268.
public-teleport-github-review-bot
Bot
removed request for
bernardjkim,
marcoandredinis,
mmcallister,
ptgott,
tigrato,
xinding33 and
zmb3
|
@eriktate you also need to update the lint workflow and integrations/terraform/Makefile to use v3.0.0 check https://github.com/gravitational/teleport/pull/47269/files |
eriktate
force-pushed
the
eriktate/update-terraform-custom-types
branch
from
50e4794 to
65dfba5
Compare
|
🤖 Vercel preview here: https://docs-8zm9257if-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-pzisfxiqs-goteleport.vercel.app/docs/ver/preview |
|
As the proto files were updated, you must re-generate everything that depends on them: make -C integrations/operator generate manifests crd-docs
make -C integrations/terraform gen-tfschema docs |
eriktate
force-pushed
the
eriktate/update-terraform-custom-types
branch
from
584f655 to
707813e
Compare
|
🤖 Vercel preview here: https://docs-qajlb7hou-goteleport.vercel.app/docs/ver/preview |
eriktate
force-pushed
the
eriktate/update-terraform-custom-types
branch
from
707813e to
a5bafb5
Compare
eriktate
force-pushed
the
eriktate/update-terraform-custom-types
branch
from
a5bafb5 to
b4c84e3
Compare
@hugoShaka I unfortunately missed this sentence and I already fixed the prose lint errors 😅 I can revert those if we really don't want to carry them through, but they were all fairly straightforward changes. There weren't really that many of them and pretty much all of them were either capitalizing |
|
🤖 Vercel preview here: https://docs-m9jwksjzy-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-7fl00ikyo-goteleport.vercel.app/docs/ver/preview |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
* adding new Attribute param to custom type generator funcs and adjusting configs to support using protoc-gen-terraform v3.0.0 * generating newly available docs for the terraform provider * fixing new lint errors
* adding new Attribute param to custom type generator funcs and adjusting configs to support using protoc-gen-terraform v3.0.0 * generating newly available docs for the terraform provider * fixing new lint errors
6 participants
Relates to #33288
This PR makes some necessary changes to update
protoc-gen-terraformtov3.0.0. It's a large PR because it also adds a bunch of terraform provider reference documentation that was failing to generate before. For that reason, this is split into two commits. The first one contains the actual code/configuration changes required to move tov3.0.0. The second contains only the generated documentation changes. I don't think I can actually split this into multiple PRs due to the linter requiring terraform generation to run, but if there's a good way to make this smaller I'm happy to do that 👍changelog: Added missing field-level documentation to the terraform provider reference.