feat: SSO MFA - add missing SAML MFA fields#47291
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
added
the
no-changelog
Closed
rosstimothy
reviewed
Oct 7, 2024
Joerger
force-pushed
the
joerger/add-missing-saml-mfa-fields
branch
from
fc10b9a to
c4646c1
Compare
Contributor
|
🤖 Vercel preview here: https://docs-5q5a95hht-goteleport.vercel.app/docs/ver/preview |
Joerger
commented
Oct 8, 2024
hugoShaka
reviewed
Oct 8, 2024
Joerger
force-pushed
the
joerger/add-missing-saml-mfa-fields
branch
from
e31504b to
6872b63
Compare
rosstimothy
approved these changes
Oct 8, 2024
Contributor
|
🤖 Vercel preview here: https://docs-isr4plvqi-goteleport.vercel.app/docs/ver/preview |
Joerger
force-pushed
the
joerger/add-missing-saml-mfa-fields
branch
from
6872b63 to
427612a
Compare
Contributor
|
🤖 Vercel preview here: https://docs-41de9ob8x-goteleport.vercel.app/docs/ver/preview |
Joerger
force-pushed
the
joerger/add-missing-saml-mfa-fields
branch
from
427612a to
451d611
Compare
Contributor
|
🤖 Vercel preview here: https://docs-3c9qx6f37-goteleport.vercel.app/docs/ver/preview |
Joerger
force-pushed
the
joerger/add-missing-saml-mfa-fields
branch
from
451d611 to
612bc4f
Compare
Contributor
|
🤖 Vercel preview here: https://docs-b45ljdcql-goteleport.vercel.app/docs/ver/preview |
Contributor
Author
|
@gzdunek @smallinsky friendly ping to review |
gzdunek
approved these changes
Oct 10, 2024
Joerger
force-pushed
the
joerger/add-missing-saml-mfa-fields
branch
from
612bc4f to
d1ecfa2
Compare
public-teleport-github-review-bot
Bot
removed the request for review
from smallinsky
Contributor
|
🤖 Vercel preview here: https://docs-hm9ytn4lr-goteleport.vercel.app/docs/ver/preview |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
mvbrock
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Add missing SAML MFA settings. * Validate saml mfa settings and set fields from entity_descriptor. * Reuse entity descriptor from base connector when applicable. * Upate terraform schema and docs and crds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #46703 adding missing fields needed for the SSO MFA flow.