[v16] Unify and simplify MFA Ceremony helpers#47157
Merged
Joerger merged 2 commits intobranch/v16from Oct 16, 2024
Merged
Conversation
* Refactor MFA ceremony helpers. * Refactor session MFA ceremony to use new MFA ceremony helpers. * Simplify calls to NewMFACeremony. * Remove remaining usage of tc.PromptMFA in favor of Ceremony. * Rename prompt constructor. * Add godoc to ceremony; update tests. * Cleanup. * Resolve comments; fix tests. * Update comments. * Fix test. * Fix lint.
Joerger
force-pushed
the
joerger/v16/mfa-ceremony-refactor
branch
from
f38a210 to
991db45
Compare
github-actions
Bot
added
backport
desktop-access
size/sm
tsh
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
1 similar comment
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
probakowski
approved these changes
Oct 8, 2024
Joerger
added
the
no-changelog
rosstimothy
approved these changes
Oct 8, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from codingllama
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #46986 to branch/v16