Unify and simplify MFA Ceremony helpers#46986
Merged
Conversation
Joerger
added
no-changelog
github-actions
Bot
added
desktop-access
size/sm
tsh
codingllama
reviewed
Oct 1, 2024
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Looks good, no major comments on my part.
Please take a look at the test failures.
Joerger
force-pushed
the
joerger/mfa-ceremony-refactor
branch
from
28edc50 to
09dbce8
Compare
Closed
probakowski
approved these changes
Oct 2, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from bl-nero
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Refactor MFA ceremony helpers. * Refactor session MFA ceremony to use new MFA ceremony helpers. * Simplify calls to NewMFACeremony. * Remove remaining usage of tc.PromptMFA in favor of Ceremony. * Rename prompt constructor. * Add godoc to ceremony; update tests. * Cleanup. * Resolve comments; fix tests. * Update comments. * Fix test. * Fix lint.
Joerger
added a commit
that referenced
this pull request
Oct 3, 2024
* Refactor MFA ceremony helpers. * Refactor session MFA ceremony to use new MFA ceremony helpers. * Simplify calls to NewMFACeremony. * Remove remaining usage of tc.PromptMFA in favor of Ceremony. * Rename prompt constructor. * Add godoc to ceremony; update tests. * Cleanup. * Resolve comments; fix tests. * Update comments. * Fix test. * Fix lint.
Contributor
Author
|
There are many more hard to fix conflicts with the v15 backport than I would have hoped., so I'm going to hold off on it unless absolutely necessary. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Refactor MFA ceremony helpers. * Refactor session MFA ceremony to use new MFA ceremony helpers. * Simplify calls to NewMFACeremony. * Remove remaining usage of tc.PromptMFA in favor of Ceremony. * Rename prompt constructor. * Add godoc to ceremony; update tests. * Cleanup. * Resolve comments; fix tests. * Update comments. * Fix test. * Fix lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to the previous MFA Ceremony PR to unify MFA ceremonies with the same ceremony helpers. I also took steps to simplify the ceremony helpers. This change will make it easier to apply MFA ceremony changes, such as SSO MFA to one spot rather than several slightly modified spots.
This PR should have no functional impact.