feat: SSO MFA - support for SAML ForceAuthn for login and mfa checks#46703
Merged
feat: SSO MFA - support for SAML ForceAuthn for login and mfa checks#46703
ForceAuthn for login and mfa checks#46703Conversation
Joerger
added
the
no-changelog
Closed
Joerger
force-pushed
the
joerger/auth-connector-mfa-settings
branch
from
f4f51dc to
3cf210a
Compare
Joerger
force-pushed
the
joerger/auth-connector-mfa-settings
branch
from
3cf210a to
798c5e3
Compare
Joerger
force-pushed
the
joerger/saml-force-auth
branch
from
062ea0f to
7273f61
Compare
Base automatically changed from
joerger/auth-connector-mfa-settings
to
master
September 30, 2024 19:51
Joerger
force-pushed
the
joerger/saml-force-auth
branch
from
7273f61 to
48be7f8
Compare
Contributor
Author
|
@GavinFrazar @r0mant Friendly ping for review, would be good to get this config change into v17 |
rosstimothy
reviewed
Oct 2, 2024
GavinFrazar
approved these changes
Oct 2, 2024
Joerger
force-pushed
the
joerger/saml-force-auth
branch
from
48be7f8 to
60f782a
Compare
rosstimothy
approved these changes
Oct 7, 2024
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
LGTM, though, can we add some test coverage that validates each option does the appropriate thing when YES/NO/UNSPECIFIED is set?
public-teleport-github-review-bot
Bot
removed the request for review
from r0mant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the implementation of SSO MFA
Depends on #46687
Updates #30844