feat: SSO MFA - Add Auth Connector MFA settings protobuf and methods.#46687
feat: SSO MFA - Add Auth Connector MFA settings protobuf and methods.#46687
protobuf and methods.#46687Conversation
f72c0f5 to
f4f51dc
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
f4f51dc to
3cf210a
Compare
3cf210a to
798c5e3
Compare
|
@fspmarshall friendly reminder for review |
fspmarshall
left a comment
There was a problem hiding this comment.
At a glance it looks like at least one of the new fields is a secret. I don't know much about oidc/saml so I'm not sure which other fields may also be sensitive, but the OIDCConnector and SAMLConnector resources both implement the ResourceWithSecrets interface and implement separate RBAC controls for reading the resources with and without secrets included. In practice, what this means is that any time you add a field either of these resources, their respective WithoutSecrets method must be updated to censor/omit the field if it is secret/sensitive.
LGTM once a pass has been done on WithoutSecrets.
Part of the implementation of SSO MFA