Skip to content

[v16] Adding extra pod labels to post-upgrade and post-delete hook job pods#46232

Merged
mvbrock merged 10 commits intobranch/v16from
bot/backport-46029-branch/v16
Sep 6, 2024
Merged

[v16] Adding extra pod labels to post-upgrade and post-delete hook job pods#46232
mvbrock merged 10 commits intobranch/v16from
bot/backport-46029-branch/v16

Conversation

@mvbrock
Copy link
Copy Markdown
Contributor

@mvbrock mvbrock commented Sep 4, 2024

Backport #46029 to branch/v16

changelog: Ensure that additional pod labels are carried over to post-upgrade and post-delete hook job pods when using the teleport-kube-agent Helm chart.

Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge those backports PR yet, this will break CI

@mvbrock
Copy link
Copy Markdown
Contributor Author

mvbrock commented Sep 6, 2024

Please don't merge those backports PR yet, this will break CI

@hugoShaka can you give a little more detail? Should I fix something before merging?

@hugoShaka
Copy link
Copy Markdown
Contributor

hugoShaka commented Sep 6, 2024

Sorry, I forgot to ping you, the fix passed, You can now rebase on branch/v16 (you already did). The CI now enforces the chart documentation to be in sync with the chart values, it won't let the PR break the tests anymore.

After rebasing you might face a CI error asking to re-generate the docs, it will contain the command to do so.

Edit: you can find the failed run here with the fix instructions:

Checking teleport-operator reference
Checking teleport-kube-agent reference
1502c1502
< Deployment or StatefulSet.
---
> Deployment, StatefulSet, or Job.
Chart values.yaml and reference differ, please run 'make -C examples/chart render-chart-ref'
make[1]: *** [Makefile:58: check-chart-ref-teleport-kube-agent] Error 1
make[1]: Leaving directory '/__w/teleport/teleport/examples/chart'
make: *** [Makefile:1200: lint-helm] Error 2

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from jakule September 6, 2024 16:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 6, 2024

🤖 Vercel preview here: https://docs-cos5cnpy8-goteleport.vercel.app/docs/ver/preview

@mvbrock mvbrock added this pull request to the merge queue Sep 6, 2024
Merged via the queue into branch/v16 with commit aa18501 Sep 6, 2024
@mvbrock mvbrock deleted the bot/backport-46029-branch/v16 branch September 6, 2024 17:33
@fheinecke fheinecke mentioned this pull request Apr 9, 2025
@fheinecke fheinecke mentioned this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants