[v16] Adding extra pod labels to post-upgrade and post-delete hook job pods#46232
Merged
mvbrock merged 10 commits intobranch/v16from Sep 6, 2024
Merged
[v16] Adding extra pod labels to post-upgrade and post-delete hook job pods#46232mvbrock merged 10 commits intobranch/v16from
mvbrock merged 10 commits intobranch/v16from
Conversation
Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
approved these changes
Sep 4, 2024
hugoShaka
requested changes
Sep 4, 2024
Contributor
hugoShaka
left a comment
There was a problem hiding this comment.
Please don't merge those backports PR yet, this will break CI
Contributor
Author
@hugoShaka can you give a little more detail? Should I fix something before merging? |
Contributor
|
Sorry, I forgot to ping you, the fix passed, After rebasing you might face a CI error asking to re-generate the docs, it will contain the command to do so. Edit: you can find the failed run here with the fix instructions: |
hugoShaka
approved these changes
Sep 6, 2024
Contributor
|
🤖 Vercel preview here: https://docs-cos5cnpy8-goteleport.vercel.app/docs/ver/preview |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #46029 to branch/v16
changelog: Ensure that additional pod labels are carried over to post-upgrade and post-delete hook job pods when using the teleport-kube-agent Helm chart.