ci: Ensure Helm lint is run on helm changes#46243
Merged
Conversation
hugoShaka
requested review from
camscale,
codingllama,
fheinecke,
klizhentas,
r0mant,
rosstimothy,
russjones,
tcsc and
zmb3
as code owners
hugoShaka
added
bug
no-changelog
github-actions
Bot
requested review from
marcoandredinis,
mmcallister,
ptgott and
xinding33
tigrato
approved these changes
Sep 4, 2024
jakule
approved these changes
Sep 4, 2024
Contributor
|
🤖 Vercel preview here: https://docs-nxte4ylpg-goteleport.vercel.app/docs/ver/preview |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Lint on Helm changes rather than go changes * Re-render Helm docs + improve out-of-sync error message * address feedback
r0mant
approved these changes
Sep 4, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@hugoShaka See the table below for backport results.
|
hugoShaka
added a commit
that referenced
this pull request
Sep 4, 2024
* Lint on Helm changes rather than go changes * Re-render Helm docs + improve out-of-sync error message * address feedback
hugoShaka
added a commit
that referenced
this pull request
Sep 4, 2024
* Lint on Helm changes rather than go changes * Re-render Helm docs + improve out-of-sync error message * address feedback
hugoShaka
added a commit
that referenced
this pull request
Sep 4, 2024
* Lint on Helm changes rather than go changes * Re-render Helm docs + improve out-of-sync error message * address feedback
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* ci: Ensure Helm lint is run on helm changes (#46243) * Lint on Helm changes rather than go changes * Re-render Helm docs + improve out-of-sync error message * address feedback * re-render chart ref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures Helm lint is run on Helm changes by moving the helm lint out of the no-action Make target which was run only on go changes.
This should catch PRs that missed to re-render the docs.