Adding extra pod labels to post-upgrade and post-delete hook job pods#46029
Adding extra pod labels to post-upgrade and post-delete hook job pods#46029
Conversation
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
There was a problem hiding this comment.
Please check the HELM tests job because they are currently failing:
https://github.com/gravitational/teleport/actions/runs/10618573216/job/29434142089?pr=46029
The changelog should be a customer-focused message that clearly communicates what has changed, such as:
Changelog: Ensure that additional pod labels are carried over to post-upgrade and post-delete hook job pods when using the teleport-kube-agent Helm chart.
There was a problem hiding this comment.
I think we can remove this hook because it was only important for v10--> v11 migration.
Since we are in v16 and v11 is not supported since v14, it should be fine to delete the whole hook
Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
There was a problem hiding this comment.
After debugging a situation with a customer, I realized this is still useful. can you please re-add it and add support for the annotations and labels?
sorry about the confusion
Adding extra pod labels to the post-upgrade and post-delete hook job pods. Verified that the labels show up in the post delete hook when uninstalling the kube-agent Helm chart:
Fixes: #45114
Changelog: Ensure that additional pod labels are carried over to post-upgrade and post-delete hook job pods when using the teleport-kube-agent Helm chart.