Introduce a member count method to access lists.#38650
Conversation
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
mdwn
requested review from
espadolini and
tigrato
and removed request for
fspmarshall and
rudream
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
mdwn
force-pushed
the
mike.wilson/take-4-access-list-member-count
branch
from
d2340ad to
abbba97
Compare
mdwn
force-pushed
the
mike.wilson/take-4-access-list-member-count
branch
from
f02c8a8 to
3cfd71c
Compare
tigrato
left a comment
tigrato
left a comment
There was a problem hiding this comment.
We probably need to update https://github.com/gravitational/protoc-gen-terraform as well
There was a problem hiding this comment.
What does this test tests?
Only if FromProto doesn't return any error? It still doesn't validate if the members count was propagated from and to protons
There was a problem hiding this comment.
This effectively makes sure that the member count being nil doesn't break/panic. The RoundTrip test function tests the propagation.
mdwn
force-pushed
the
mike.wilson/take-4-access-list-member-count
branch
from
a9689c1 to
1accdaa
Compare
The access list interface now supports counting members without unmarshaling. This method has been added to the generic backend service as well. This will allow for quicker counts when necessary. This method has been added to the cache. Additionally, a status field as per RFD-153 has been added to access lists that will house the new optional member count field.
mdwn
force-pushed
the
mike.wilson/take-4-access-list-member-count
branch
from
d075eec to
fb1c102
Compare
6 participants
The access list interface now supports counting members without unmarshaling. This method has been added to the generic backend service as well. This will allow for quicker counts when necessary.
Additionally, a status field as per RFD-153 has been added to access lists that will house the new optional member count field.
This is on a test cluster with roughly 562 access lists and 20,000+ access list members. This is an improvement from 3.5 seconds per retrieval.
changelog: The Access List page in the UI has been heavily optimized, which should speed things up considerably.
Depends on: