GCP backend cleanup and safety improvements #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2020 15:26
- close all io.Closers where missing - add error handling where missing - improve error messages
- before uploading a session, check that it doesn't already exist; we don't want to lose an existing session - when auto-creating a missing bucket at startup, set predefined ACLs to `projectPrivate`, which means "Project team members get access according to their roles." See https://cloud.google.com/storage/docs/json_api/v1/buckets/insert#parameters
awly
force-pushed
the
andrew/gcp-backend-cleanup
branch
from
1db8c54 to
db634da
Compare
added 2 commits
May 26, 2020 15:40
Tests run against an in-memory mock GCS, no need to guard them with a build tag.
Reimplement cleanup code in the test itself, since the helper method is gone.
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
|
retest this please |
webvictim
approved these changes
May 27, 2020
|
LGTM. 👍 As discussed with @awly over e-mail my current use case is for two clusters that aren't super critical (and are managed by Puppet and can easily be rebuilt) and have event data we are able to forfeit. |
russjones
approved these changes
May 27, 2020
awly
pushed a commit
that referenced
this pull request
Jul 14, 2020
#3766 removed a nil pointer check when creating firestore indexes. This was a legitimate check, for when indexes already exist. Tested this manually. Unit testing is trickier because the firestore emulator in gcloud doesn't support indexes.
awly
pushed a commit
that referenced
this pull request
Jul 15, 2020
#3766 removed a nil pointer check when creating firestore indexes. This was a legitimate check, for when indexes already exist. Tested this manually. Unit testing is trickier because the firestore emulator in gcloud doesn't support indexes.
awly
pushed a commit
that referenced
this pull request
Jul 15, 2020
#3766 removed a nil pointer check when creating firestore indexes. This was a legitimate check, for when indexes already exist. Tested this manually. Unit testing is trickier because the firestore emulator in gcloud doesn't support indexes.
awly
pushed a commit
that referenced
this pull request
Jul 15, 2020
#3766 removed a nil pointer check when creating firestore indexes. This was a legitimate check, for when indexes already exist. Tested this manually. Unit testing is trickier because the firestore emulator in gcloud doesn't support indexes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/backend/firestoreto avoid data corruptionGetAllcallsFixes #3015