Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Review of GCP Backend #3015

Closed
russjones opened this issue Sep 24, 2019 · 1 comment · Fixed by #3766
Closed

Security Review of GCP Backend #3015

russjones opened this issue Sep 24, 2019 · 1 comment · Fixed by #3766
Assignees
Labels
security Security Issues

Comments

@russjones
Copy link
Contributor

The new GCP backend introduced in #3014 needs a security review before cutting 4.2.

At the minimum session upload needs to be checked that it doesn't clobber an existing session recording.

@russjones russjones added this to the 4.2 "Alameda" milestone Sep 24, 2019
@russjones russjones self-assigned this Sep 24, 2019
@benarent benarent added the security Security Issues label Nov 1, 2019
@awly awly self-assigned this May 14, 2020
@awly
Copy link
Contributor

awly commented May 26, 2020

Notes from review:

  • session upload could indeed overwrite a previous upload
  • lib/backend/firestore key escaping could lead to data corruption by mapping different teleport keys to the same firestore documentIDs
  • some minor bugs like unhandled errors, possible nil pointer dereferences, missing connection/resource cleanup
  • some stylistic problems (that aren't bugs)

Sent #3766 to fix all found problems, except for stylistic ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Security Issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants