Fix a nil pointer dereference in firestore index creation #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#3766 removed a nil pointer check when creating firestore indexes. This was a legitimate check, for when indexes already exist. Tested this manually. Unit testing is trickier because the firestore emulator in gcloud doesn't support indexes.
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
webvictim
approved these changes
Jul 15, 2020
|
retest this please |
klizhentas
approved these changes
Jul 15, 2020
|
What are the plans to include that in 4.3 series? Given the issues that we have with 4.2 enterprise we wanted to switch to 4.3 ent but sadly broken firestore is showstopper for us. |
|
This will be released with Teleport 4.3.1. The planned release date is Monday 27th July. |
|
@pigmej This has been released as v4.3.2. You can access the downloads here, https://gravitational.com/teleport/download. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3766 removed a nil
pointer check when creating firestore indexes. This was a legitimate
check, for when indexes already exist.
Tested this manually. Unit testing is trickier because the firestore
emulator in gcloud doesn't support indexes.