Use FIDO2 touch functions to wait for touch#37203
Merged
codingllama merged 5 commits intomasterfrom Jan 31, 2024
Merged
Conversation
codingllama
added
backport/branch/v13
no-changelog
Contributor
Author
codingllama
commented
Jan 24, 2024
| if touched, _ := waitForTouch(dev); touched { | ||
| err = nil // OK, selected successfully | ||
| } else { | ||
| err = &nonInteractiveError{err: err} |
Contributor
Author
There was a problem hiding this comment.
I didn't spot any problems during testing, but arguably this line should be a part of #37181.
tigrato
reviewed
Jan 26, 2024
Contributor
Author
|
PTAL? |
tigrato
approved these changes
Jan 29, 2024
rosstimothy
reviewed
Jan 29, 2024
Contributor
Author
|
PTAL? |
codingllama
force-pushed
the
codingllama/fido2-st-device
branch
from
d670c01 to
1042150
Compare
codingllama
force-pushed
the
codingllama/fido2-get-touch
branch
from
e8ebf19 to
5a2d73c
Compare
Contributor
Author
|
PTAL @rosstimothy ? |
codingllama
force-pushed
the
codingllama/fido2-get-touch
branch
from
5a2d73c to
9942bdd
Compare
Contributor
Author
|
Rebased onto master, diffs should be clear again. |
Contributor
Author
|
Friendly ping @rosstimothy @greedy52? I would like to get all FIDO2 changes merged close together, so hopefully they all land in a single release. |
rosstimothy
approved these changes
Jan 31, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from greedy52
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
Jan 31, 2024
* Use FIDO2 touch functions to wait for touch * nit: Initialize nonInteractiveError uniformly * Change fido2TouchMaxWait to 200ms * Log dev.TouchBegin() errors * Apply various error-handling fixes
This was referenced Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use libfido2 touch polling functions instead of fake assertions when trying to determine if a device was touched.
The touch functions make it simpler to decide if the device was actually touched and likely cause less unnecessary work for the authenticator.
#36640