Skip to content

feat: Add support for fido_dev_get_touch_{begin,status}#17

Merged
codingllama merged 2 commits intoteleportfrom
codingllama/touch-begin
Jan 30, 2024
Merged

feat: Add support for fido_dev_get_touch_{begin,status}#17
codingllama merged 2 commits intoteleportfrom
codingllama/touch-begin

Conversation

@codingllama
Copy link
Copy Markdown

Add support for touch polling operations. These are simpler to code against than fake assertions and clearer in their outcome. Additionally, they work with both U2F and FIDO2 keys seamlessly.

Example:

touch, err := dev.TouchBegin()
if err != nil {
	panic(err)
}
defer touch.Stop()

for {
	touched, err := touch.Status(maxWait)
	if err != nil {
		panic(err)
	}
	if touched {
		break // Done!
	}
}

@codingllama
Copy link
Copy Markdown
Author

The API could go in many different ways, let me know if you have other ideas.

@codingllama
Copy link
Copy Markdown
Author

Friendly ping @rosstimothy ?

Comment thread fido2.go
Comment thread fido2.go
@codingllama
Copy link
Copy Markdown
Author

PTAL?

@codingllama codingllama merged commit 895a795 into teleport Jan 30, 2024
@codingllama codingllama deleted the codingllama/touch-begin branch January 30, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants