feat: Add support for fido_dev_get_touch_{begin,status}#17
Merged
codingllama merged 2 commits intoteleportfrom Jan 30, 2024
Merged
feat: Add support for fido_dev_get_touch_{begin,status}#17codingllama merged 2 commits intoteleportfrom
codingllama merged 2 commits intoteleportfrom
Conversation
Author
|
The API could go in many different ways, let me know if you have other ideas. |
Author
|
Friendly ping @rosstimothy ? |
rosstimothy
reviewed
Jan 29, 2024
Author
|
PTAL? |
rosstimothy
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for touch polling operations. These are simpler to code against than fake assertions and clearer in their outcome. Additionally, they work with both U2F and FIDO2 keys seamlessly.
Example: