Skip the RPID pre-flight check whenever possible#37542
Merged
codingllama merged 1 commit intomasterfrom Jan 31, 2024
Merged
Conversation
Contributor
Author
Contributor
Author
|
Friendly ping reviewers? I would like to get all FIDO2 changes merged close together, so hopefully they all land in a single release. |
gzdunek
approved these changes
Jan 31, 2024
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
Looks good, but I'm not an expert.
Contributor
Author
Thanks for giving it a go. I'm not sure I could say that even I'm an expert, given how much trouble this has caused me historically (and lately). 😊 |
tigrato
approved these changes
Jan 31, 2024
public-teleport-github-review-bot
Bot
removed request for
jakule and
rosstimothy
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
Jan 31, 2024
This was referenced Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the RPID and AppID pre-flight check whenever an App ID is not present (which should be true for the majority of clusters).
This avoids an additional security key operation in most scenarios, which should make solving assertions generally faster.
#36640
Changelog: Skip tsh AppID pre-flight check whenever possible