Skip to content

MFA Auth Audit Events#36953

Merged
Joerger merged 6 commits intomasterfrom
joerger/mfa-audit-events
Jan 23, 2024
Merged

MFA Auth Audit Events#36953
Joerger merged 6 commits intomasterfrom
joerger/mfa-audit-events

Conversation

@Joerger
Copy link
Copy Markdown
Contributor

@Joerger Joerger commented Jan 19, 2024

Add MFA Auth events for creation and validation, as mentioned in RFD 155

Based off #36830

@github-actions github-actions Bot added audit-log Issues related to Teleports Audit Log size/md labels Jan 19, 2024
@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Jan 19, 2024
@Joerger Joerger changed the title MFA Auth events MFA Auth Audit Events Jan 20, 2024
@Joerger Joerger force-pushed the joerger/mfa-audit-events branch from c34da20 to 1a8b344 Compare January 20, 2024 00:40
@Joerger
Copy link
Copy Markdown
Contributor Author

Joerger commented Jan 20, 2024

@zmb3 Just FYI I pushed some changes after you approved:

  • Change Scope and AllowReuse to string and bool respectively for better readability
  • Add Client / Web changes to display the event properly

@Joerger Joerger mentioned this pull request Jan 20, 2024
@Joerger Joerger force-pushed the joerger/mfa-audit-events branch from 2b22b87 to f880838 Compare January 20, 2024 02:23
@Joerger Joerger mentioned this pull request Jan 20, 2024
14 tasks
@Joerger Joerger force-pushed the joerger/admin-actions-allow-reuse branch from 114e0e7 to cf9c4d6 Compare January 21, 2024 21:28
@Joerger Joerger force-pushed the joerger/mfa-audit-events branch from f880838 to 2ba2a38 Compare January 21, 2024 21:29
@Joerger Joerger force-pushed the joerger/admin-actions-allow-reuse branch from ff193b0 to 12165a1 Compare January 22, 2024 19:19
Base automatically changed from joerger/admin-actions-allow-reuse to master January 22, 2024 20:22
@Joerger Joerger added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 23, 2024
@Joerger Joerger added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 23, 2024
@Joerger Joerger added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 23, 2024
@Joerger Joerger added this pull request to the merge queue Jan 23, 2024
Merged via the queue into master with commit 218d608 Jan 23, 2024
@Joerger Joerger deleted the joerger/mfa-audit-events branch January 23, 2024 04:29
@public-teleport-github-review-bot
Copy link
Copy Markdown

@Joerger See the table below for backport results.

Branch Result
branch/v15 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-log Issues related to Teleports Audit Log no-changelog Indicates that a PR does not require a changelog entry size/md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants