Allow reused MFA for specific admin action endpoints#36830
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
added
no-changelog
Joerger
force-pushed
the
joerger/scoped-webauthn-server-changes
branch
from
3cedcff to
e1f8d74
Compare
Joerger
force-pushed
the
joerger/admin-actions-allow-reuse
branch
from
5ebc037 to
0253bf1
Compare
mdwn
approved these changes
Jan 17, 2024
Joerger
force-pushed
the
joerger/scoped-webauthn-server-changes
branch
2 times, most recently
from
2358283 to
08217e1
Compare
Joerger
force-pushed
the
joerger/admin-actions-allow-reuse
branch
from
0253bf1 to
bfdf2d4
Compare
rosstimothy
reviewed
Jan 18, 2024
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
It looks like this might have broken a few existing tests
Joerger
force-pushed
the
joerger/scoped-webauthn-server-changes
branch
from
08217e1 to
3cb9d1f
Compare
Joerger
force-pushed
the
joerger/admin-actions-allow-reuse
branch
2 times, most recently
from
21a9145 to
ad770eb
Compare
rosstimothy
approved these changes
Jan 18, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from zmb3
Joerger
force-pushed
the
joerger/scoped-webauthn-server-changes
branch
from
a651395 to
96d7b0a
Compare
Joerger
force-pushed
the
joerger/admin-actions-allow-reuse
branch
from
5798593 to
114e0e7
Compare
Merged
Joerger
force-pushed
the
joerger/scoped-webauthn-server-changes
branch
from
96d7b0a to
d7b053f
Compare
Joerger
force-pushed
the
joerger/admin-actions-allow-reuse
branch
from
114e0e7 to
cf9c4d6
Compare
Base automatically changed from
joerger/scoped-webauthn-server-changes
to
master
January 22, 2024 19:11
Joerger
force-pushed
the
joerger/admin-actions-allow-reuse
branch
from
ff193b0 to
12165a1
Compare
Joerger
added a commit
that referenced
this pull request
Jan 23, 2024
* Allow reused MFA for specific admin action endpoints. * Add godoc. * Fix IsMFARequire_AdminAction and add test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the implementation for #35185
Follow up PRs: Use reused MFA for...
tctl createactionstctlBased off #36782