fix: Correctly handle passwordless in MFA audit events#40607
Merged
codingllama merged 3 commits intomasterfrom Apr 17, 2024
Merged
fix: Correctly handle passwordless in MFA audit events#40607codingllama merged 3 commits intomasterfrom
codingllama merged 3 commits intomasterfrom
Conversation
Contributor
Author
codingllama
commented
Apr 16, 2024
| clusterName = cn.GetClusterName() | ||
| } | ||
|
|
||
| // Take the user from the authData if the user param is empty. |
Contributor
Author
There was a problem hiding this comment.
The code here is mainly a move from below, minus the user == "" logic you see here.
Contributor
Author
There was a problem hiding this comment.
I opted for an "internal" func so we avoid shenanigans with defers reading named return variables, which can be harder to maintain over time.
zmb3
approved these changes
Apr 16, 2024
rosstimothy
approved these changes
Apr 17, 2024
public-teleport-github-review-bot
Bot
removed request for
ravicious and
rudream
Contributor
Author
|
Thanks for the quick reviews! |
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
Apr 17, 2024
* Record passwordless username in the mfa_auth_challenge.validate event * Correctly render mfa_auth_challenge.create events without an user * Update snapshots
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
* fix: Correctly handle passwordless in MFA audit events (#40607) * Record passwordless username in the mfa_auth_challenge.validate event * Correctly render mfa_auth_challenge.create events without an user * Update snapshots * Update snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do the following fixes:
Fixes #37826.
Changelog: Handle passwordless in MFA audit events