Skip to content

Scoped WebAuthn: server changes#36782

Merged
Joerger merged 7 commits intomasterfrom
joerger/scoped-webauthn-server-changes
Jan 22, 2024
Merged

Scoped WebAuthn: server changes#36782
Joerger merged 7 commits intomasterfrom
joerger/scoped-webauthn-server-changes

Conversation

@Joerger
Copy link
Copy Markdown
Contributor

@Joerger Joerger commented Jan 17, 2024

Propagate MFA challenge extensions through MFA challenge creation & response validation flows.

Part of the implementation for #35185

Based off #36667

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 17, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@Joerger Joerger force-pushed the joerger/scoped-webauthn-server-changes branch from 9a95c13 to 1bb735b Compare January 17, 2024 04:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 17, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@Joerger Joerger changed the title Scoped Webauthn: server changes Scoped WebAuthn: server changes Jan 17, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 17, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

mdwn
mdwn approved these changes Jan 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mdwn mdwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the scopes themselves, but overall LGTM. Two small things.

Comment thread api/proto/teleport/legacy/types/webauthn/webauthn.proto Outdated
Comment thread lib/auth/webauthn/login_test.go Outdated
@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Jan 17, 2024
@codingllama
Copy link
Copy Markdown
Contributor

codingllama commented Jan 17, 2024

@Joerger, would you mind changing the PR base so we get a clean view of the diffs?

@Joerger Joerger changed the base branch from master to joerger/scoped-webauthn-extension-flow January 17, 2024 18:19
@Joerger Joerger force-pushed the joerger/scoped-webauthn-extension-flow branch from fde16ef to 0d2d119 Compare January 17, 2024 18:51
@Joerger Joerger force-pushed the joerger/scoped-webauthn-server-changes branch from d4b77bc to 3cedcff Compare January 17, 2024 18:57
@Joerger
Copy link
Copy Markdown
Contributor Author

Joerger commented Jan 17, 2024

@Joerger, would you mind changing the PR base so we get a clean view of the diffs?

Done, ptal

@Joerger Joerger mentioned this pull request Jan 17, 2024
Merged
@Joerger Joerger force-pushed the joerger/scoped-webauthn-extension-flow branch 2 times, most recently from 4040b97 to f1ee37c Compare January 17, 2024 21:36
@Joerger Joerger force-pushed the joerger/scoped-webauthn-server-changes branch 2 times, most recently from e1f8d74 to 2358283 Compare January 18, 2024 19:20
@Joerger Joerger force-pushed the joerger/scoped-webauthn-extension-flow branch from f1ee37c to c6a557b Compare January 18, 2024 19:26
@Joerger Joerger force-pushed the joerger/scoped-webauthn-server-changes branch from 2358283 to 08217e1 Compare January 18, 2024 19:27
ibeckermayer
ibeckermayer approved these changes Jan 18, 2024
View reviewed changes
Comment thread lib/auth/auth.go Outdated
Comment thread lib/auth/auth.go Outdated
Comment thread lib/auth/auth.go Outdated
Comment thread lib/authz/permissions.go Outdated
@Joerger Joerger force-pushed the joerger/scoped-webauthn-extension-flow branch from c6a557b to 2a8cd1f Compare January 18, 2024 20:33
@Joerger Joerger force-pushed the joerger/scoped-webauthn-server-changes branch 2 times, most recently from 021d2c5 to d69503f Compare January 18, 2024 21:26
codingllama
codingllama approved these changes Jan 19, 2024
View reviewed changes
Comment thread lib/auth/api.go Outdated
Comment thread lib/auth/webauthn/login_test.go Outdated
Comment thread lib/authz/permissions.go Outdated
Comment thread lib/authz/permissions.go Outdated
Comment thread lib/authz/permissions_test.go Outdated
Comment thread lib/authz/permissions_test.go Outdated
@codingllama
Copy link
Copy Markdown
Contributor

codingllama commented Jan 19, 2024

Looks good!

Apologies for the delay, I got consumed by the testplan the past few days. Thanks again for splitting the PRs, it made reviewing this (and the others) a breeze.

@Joerger Joerger force-pushed the joerger/scoped-webauthn-extension-flow branch from 2a8cd1f to 37e2768 Compare January 19, 2024 19:53
@Joerger Joerger force-pushed the joerger/scoped-webauthn-server-changes branch from a651395 to 96d7b0a Compare January 19, 2024 19:54
@Joerger Joerger force-pushed the joerger/scoped-webauthn-extension-flow branch from 37e2768 to 1608482 Compare January 19, 2024 22:07
Base automatically changed from joerger/scoped-webauthn-extension-flow to master January 20, 2024 00:26
@Joerger Joerger enabled auto-merge January 20, 2024 01:01
@Joerger Joerger force-pushed the joerger/scoped-webauthn-server-changes branch from 96d7b0a to d7b053f Compare January 20, 2024 01:01
@Joerger
Copy link
Copy Markdown
Contributor Author

Joerger commented Jan 20, 2024

@r0mant @zmb3 Can I get a flaky test skip? This is timing out due to the number of tests being attempted.

@r0mant
Copy link
Copy Markdown
Collaborator

r0mant commented Jan 22, 2024

/excludeflake *

@Joerger Joerger added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit d563b2c Jan 22, 2024
@Joerger Joerger deleted the joerger/scoped-webauthn-server-changes branch January 22, 2024 19:11
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Jan 22, 2024

@Joerger See the table below for backport results.

Branch Result
branch/v15 Create PR

@Joerger Joerger mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codingllama codingllama codingllama approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

+2 more reviewers

@mdwn mdwn mdwn approved these changes

@ibeckermayer ibeckermayer ibeckermayer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

desktop-access no-changelog Indicates that a PR does not require a changelog entry size/md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Joerger @codingllama @r0mant @mdwn @ibeckermayer @rosstimothy