Scoped WebAuthn: MFAChallengeExtension proto message#36665
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
added
the
no-changelog
Joerger
changed the title
MFAChallengeExtension proto messageMFAChallengeExtension proto message
zmb3
approved these changes
Jan 14, 2024
codingllama
approved these changes
Jan 15, 2024
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Thanks for the separate PR and design changes!
| // call [AuthService.IsMFARequired] in the leaf instead of setting this field. | ||
| IsMFARequiredRequest MFARequiredCheck = 5 [(gogoproto.jsontag) = "mfa_required_check,omitempty"]; | ||
| // Extensions are extensions that will be apply to the issued MFA challenge. | ||
| // Extensions only apply to webauthn challenges currently. This field is required. |
Contributor
There was a problem hiding this comment.
This field is required
Is this true? What about legacy clients?
Contributor
Author
There was a problem hiding this comment.
Right, this will not be required until v16, but v15 clients will be required to pass this in order to be compatible with v16 servers. So any clients with access to this updated proto file are required to pass it. Do you think this is worth spelling out in the proto file comment?
Contributor
There was a problem hiding this comment.
Yeah, I think it won't hurt to say that clients before v15 aren't required to supply the field.
public-teleport-github-review-bot
Bot
removed request for
flyinghermit,
nklaassen and
rosstimothy
codingllama
reviewed
Jan 15, 2024
…enclature adjustments.
rosstimothy
approved these changes
Jan 16, 2024
This was referenced Jan 17, 2024
codingllama
approved these changes
Jan 17, 2024
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
LGTM. Apologies for the delay!
Joerger
added a commit
that referenced
this pull request
Jan 17, 2024
* Add mfa challenge extensions to proto file. * Resolve comments; move new proto messages to separate proto file; nomenclature adjustments. * Use gogoproto for mfa.proto to interface with authservice.proto. * Ellaborate on ChallengeExtensions required field comment.
This was referenced Jan 17, 2024
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Add mfa challenge extensions to proto file. * Resolve comments; move new proto messages to separate proto file; nomenclature adjustments. * Use gogoproto for mfa.proto to interface with authservice.proto. * Ellaborate on ChallengeExtensions required field comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements proto file changes for scoped Webauthn challenges as described in RFD 155