Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
added
no-changelog
Joerger
force-pushed
the
joerger/scoped-webauthn-web-ui
branch
3 times, most recently
from
5bcbeef to
b4463a3
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-web-ui
branch
from
b4463a3 to
ae25f2c
Compare
Contributor
Author
|
@ibeckermayer @ryanclark Friendly ping for review, we are trying to put this into v15.0.0 |
Joerger
force-pushed
the
joerger/scoped-webauthn-web-ui
branch
from
7d41dbb to
15ae37c
Compare
ryanclark
approved these changes
Jan 22, 2024
ibeckermayer
approved these changes
Jan 22, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Joerger
force-pushed
the
joerger/scoped-webauthn-web-ui
branch
from
2e229aa to
60ab991
Compare
Joerger
added a commit
that referenced
this pull request
Jan 23, 2024
* Add mfa challenge Scope and AllowReuse to web createAuthenticateChallengeHandler. * Pass MFA challenge scope and allow-reuse from WebUI for mfa challenge requests. * Address comments.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Scoped WebAuthn: web changes (#36784) * Add mfa challenge Scope and AllowReuse to web createAuthenticateChallengeHandler. * Pass MFA challenge scope and allow-reuse from WebUI for mfa challenge requests. * Address comments. * Make challengeScope optional for ReAuthenticate to fix /e references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass MFA challenge scope and allow-reuse from the WebUI.
Part of the implementation for #35185
Based off #36665