-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Supporting changes for download tab on Cloud #36399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3aa7126
e68bff7
30a31bd
fefb4b8
b45e4d5
50fe1db
9927e75
ec406b3
6640ffb
96e596e
f22e7f4
4e1aaec
f6d5411
fc27705
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -157,14 +157,22 @@ export default class StoreUserContext extends Store<UserContext> { | |
| // has access to download either teleport binaries or the license. | ||
| // Since the page is used to download both of them, having access to one | ||
| // is enough to show access this page. | ||
| // This page is only available for `dashboards`. | ||
| // This page is only available for `dashboards` and cloud customers. | ||
| hasDownloadCenterListAccess() { | ||
| return ( | ||
| cfg.isDashboard && | ||
| (this.state.acl.license.read || this.state.acl.download.list) | ||
| cfg.isCloud || | ||
| (cfg.isDashboard && | ||
| (this.state.acl.license.read || this.state.acl.download.list)) | ||
| ); | ||
| } | ||
|
|
||
| // hasSupportPageLinkAccess checks if the user | ||
| // has access to a Support external link in the side menu. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @avatus is in the middle of removing the side bar, was the dashboard view discussed with this refactor?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is now in master btw: #36368 You may need to update how this is displayed @mcbattirola
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for pointing that out, I wasn't aware of the new topbar. I've talked with Kenny, we'll be changing some stuff around:
Since this PR doesn't introduce the top bar link, only changes the show condition, I think we can merge this and implement the changes listed above in a new PR. |
||
| // This should only be displayed on `dashboards`. | ||
| hasSupportPageLinkAccess() { | ||
| return cfg.isDashboard; | ||
| } | ||
|
|
||
| // hasAccessToAgentQuery checks for at least one valid query permission. | ||
| // Nodes require only a 'list' access while the rest of the agents | ||
| // require 'list + read'. | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.